MessageLoopProxy cleanups in remoting client.

remoting/client/chromoting_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // ChromotingClient is the controller for the Client implementation.
 
 #ifndef REMOTING_CLIENT_CHROMOTING_CLIENT_H_
 #define REMOTING_CLIENT_CHROMOTING_CLIENT_H_
 
 #include <list>
 
 #include "base/callback.h"
 #include "base/memory/weak_ptr.h"
 #include "base/time.h"
 #include "remoting/client/client_config.h"
 #include "remoting/client/chromoting_stats.h"
 #include "remoting/client/chromoting_view.h"
 #include "remoting/protocol/client_stub.h"
 #include "remoting/protocol/clipboard_stub.h"
 #include "remoting/protocol/connection_to_host.h"
 #include "remoting/protocol/input_stub.h"
 #include "remoting/protocol/video_stub.h"
 #include "remoting/jingle_glue/xmpp_proxy.h"
 
-class MessageLoop;
-
 namespace remoting {
 
 namespace protocol {
 class TransportFactory;
 }  // namespace protocol
 
 class ClientContext;
 class RectangleUpdateDecoder;
 
 // TODO(sergeyu): Move VideoStub implementation to RectangleUpdateDecoder.
 class ChromotingClient : public protocol::ConnectionToHost::HostEventCallback,
                          public protocol::ClientStub,
                          public protocol::VideoStub {
  public:
   // Objects passed in are not owned by this class.
   ChromotingClient(const ClientConfig& config,
                    ClientContext* context,
                    protocol::ConnectionToHost* connection,
                    ChromotingView* view,
-                   RectangleUpdateDecoder* rectangle_decoder,
-                   const base::Closure& client_done);
+                   RectangleUpdateDecoder* rectangle_decoder);
   virtual ~ChromotingClient();
 
+  // Start/stop the client. Must be called on the main thread.
   void Start(scoped_refptr<XmppProxy> xmpp_proxy,
              scoped_ptr<protocol::TransportFactory> transport_factory);
   void Stop(const base::Closure& shutdown_task);
-  void ClientDone();
 
   // Return the stats recorded by this client.
   ChromotingStats* GetStats();
 
   // ClipboardStub implementation for receiving clipboard data from host.
   virtual void InjectClipboardEvent(const protocol::ClipboardEvent& event)
       OVERRIDE;
 
   // CursorShapeStub implementation for receiving cursor shape updates.
   virtual void SetCursorShape(const protocol::CursorShapeInfo& cursor_shape)
@@ skipping 11 matching lines @@
 
  private:
   struct QueuedVideoPacket {
     QueuedVideoPacket(scoped_ptr<VideoPacket> packet,
                       const base::Closure& done);
     ~QueuedVideoPacket();
     VideoPacket* packet;
     base::Closure done;
   };
 
-  base::MessageLoopProxy* message_loop();
+  base::SingleThreadTaskRunner* task_runner();

[Wez, 2012/06/11 22:32:44]

nit: It would be simpler to just take a scoped_refptr<> to the TaskRunner rather
than reach it through ClientContext every time.

[Wez, 2012/06/11 22:32:44]

nit: Where is SingleThreadTaskRunner defined in the #includes? I think you
probably still need a forward-define here to satisy IWYU?

[Sergey Ulanov, 2012/06/11 23:35:56]

Done.

[Sergey Ulanov, 2012/06/11 23:35:56]

Done.

 
   // Initializes connection.
   void Initialize();
 
   // If a packet is not being processed, dispatches a single message from the
   // |received_packets_| queue.
   void DispatchPacket();
 
   // Callback method when a VideoPacket is processed.
   // If |last_packet| is true then |decode_start| contains the timestamp when
@@ skipping 31 matching lines @@
   // WeakPtr used to avoid tasks accessing the client after it is deleted.
   base::WeakPtrFactory<ChromotingClient> weak_factory_;
   base::WeakPtr<ChromotingClient> weak_ptr_;
 
   DISALLOW_COPY_AND_ASSIGN(ChromotingClient);
 };
 
 }  // namespace remoting
 
 #endif  // REMOTING_CLIENT_CHROMOTING_CLIENT_H_