Issue 10454017: [cros] Add support for transparent background in sign in screen.

Issue 10454017: [cros] Add support for transparent background in sign in screen. (Closed)

Created:
8 years, 7 months ago by Nikita (slow)

Modified:
8 years, 6 months ago

Reviewers:
xiyuan

CC:
chromium-reviews, arv (Not doing code reviews), stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[cros] Add support for transparent background in sign in screen. Add flag for OOBE / sign in redesign. Current implementation requires that --force-compositing-mode is removed (see http://crbug.com/129787) BUG=129798, 129799 TEST=Manual. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139233

Patch Set 1 #

Patch Set 2 : ~ #

Total comments: 2

Patch Set 3 : pass screen type #

Patch Set 4 : revert test css change #

Patch Set 5 : fix build #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -3 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/webui_login_display_host.cc	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/webui_login_view.cc	View	1	3 chunks	+21 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/chromeos/login/login.html	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/chromeos/login/oobe.css	View	1 2	1 chunk	+5 lines, -1 line	0 comments	Download
M	chrome/browser/resources/chromeos/login/oobe.html	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/chromeos/login/screen_gaia_signin.css	View	1 3	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/oobe_ui.cc	View	1 2 3 4	3 chunks	+13 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

Please take a look. Started development under the flag. Hope to have filter all changes ...

8 years, 7 months ago (2012-05-25 20:10:55 UTC) #1

xiyuan

lgtm http://codereview.chromium.org/10454017/diff/2001/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (right): http://codereview.chromium.org/10454017/diff/2001/chrome/browser/about_flags.cc#newcode751 chrome/browser/about_flags.cc:751: "enable-new-oobe", nit: indentataion seems wrong.

8 years, 7 months ago (2012-05-25 20:28:15 UTC) #2

Nikita (slow)

8 years, 6 months ago (2012-05-28 08:48:00 UTC) #3

http://codereview.chromium.org/10454017/diff/2001/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

http://codereview.chromium.org/10454017/diff/2001/chrome/browser/about_flags....
chrome/browser/about_flags.cc:751: "enable-new-oobe",
On 2012/05/25 20:28:15, xiyuan wrote:
> nit: indentataion seems wrong.

Done.

Expand Messages | Collapse Messages