Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10453064: Remove V1 authenticators. (Closed)

Created:
8 years, 6 months ago by Sergey Ulanov
Modified:
8 years, 6 months ago
Reviewers:
Wez
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Remove V1 authenticators. All currently used versions of chromoting should support V2 auth, so we no longer need V1 auth support. BUG=110483 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139424

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -408 lines) Patch
M remoting/client/chromoting_client.cc View 2 chunks +3 lines, -9 lines 0 comments Download
M remoting/client/client_config.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/client/client_config.cc View 1 chunk +1 line, -2 lines 1 comment Download
M remoting/client/plugin/chromoting_instance.cc View 1 chunk +12 lines, -18 lines 0 comments Download
M remoting/client/plugin/chromoting_scriptable_object.cc View 1 chunk +12 lines, -21 lines 0 comments Download
M remoting/protocol/it2me_host_authenticator_factory.cc View 2 chunks +3 lines, -9 lines 0 comments Download
M remoting/protocol/me2me_host_authenticator_factory.cc View 2 chunks +0 lines, -11 lines 0 comments Download
D remoting/protocol/v1_authenticator.h View 1 chunk +0 lines, -75 lines 0 comments Download
D remoting/protocol/v1_authenticator.cc View 1 chunk +0 lines, -168 lines 0 comments Download
D remoting/protocol/v1_authenticator_unittest.cc View 1 chunk +0 lines, -91 lines 0 comments Download
M remoting/remoting.gyp View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sergey Ulanov
8 years, 6 months ago (2012-05-29 21:31:31 UTC) #1
Wez
lgtm http://codereview.chromium.org/10453064/diff/1/remoting/client/client_config.cc File remoting/client/client_config.cc (right): http://codereview.chromium.org/10453064/diff/1/remoting/client/client_config.cc#newcode9 remoting/client/client_config.cc:9: ClientConfig::ClientConfig() { Seems a shame to keep this ...
8 years, 6 months ago (2012-05-29 21:47:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10453064/1
8 years, 6 months ago (2012-05-29 21:52:52 UTC) #3
commit-bot: I haz the power
8 years, 6 months ago (2012-05-29 23:40:35 UTC) #4 
Change committed as 139424

Powered by Google App Engine
This is Rietveld 408576698