Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4216)

Unified Diff: chrome/browser/ui/views/uninstall_view.cc

Issue 10453048: Remove widgets related to restoring the default browser from uninstall view when default settings c… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Updated for changed deps. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/uninstall_view.cc
diff --git a/chrome/browser/ui/views/uninstall_view.cc b/chrome/browser/ui/views/uninstall_view.cc
index 3c8e6326b465f81c2d64b983180799f135930262..8f15049090dab6556be683563549c8be664a04ab 100644
--- a/chrome/browser/ui/views/uninstall_view.cc
+++ b/chrome/browser/ui/views/uninstall_view.cc
@@ -69,10 +69,14 @@ void UninstallView::SetupControls() {
l10n_util::GetStringUTF16(IDS_UNINSTALL_DELETE_PROFILE));
layout->AddView(delete_profile_);
- // Set default browser combo box
+ // Set default browser combo box. We assume here that if Chrome cannot
+ // be set automatically as default, neither can any other browser (for
gab 2012/06/07 19:13:28 automatically --> programmatically
motek. 2012/06/08 15:03:32 Done.
+ // instance because the distribution or the OS doesn't permit that.
gab 2012/06/07 19:13:28 "." => ")."
gab 2012/06/07 19:13:28 -distribution (i.e. our distribution is not the bl
motek. 2012/06/08 15:03:32 Done.
motek. 2012/06/08 15:03:32 Done + clarified a bit (because we indeed don't sh
BrowserDistribution* dist = BrowserDistribution::GetDistribution();
if (dist->CanSetAsDefault() &&
- ShellIntegration::IsDefaultBrowser()) {
+ ShellIntegration::IsDefaultBrowser() &&
+ ShellIntegration::CanSetAsDefaultBrowser() !=
+ ShellIntegration::SET_DEFAULT_INTERACTIVE) {
browsers_.reset(new BrowsersMap());
ShellUtil::GetRegisteredBrowsers(dist, browsers_.get());
if (!browsers_->empty()) {
@@ -129,7 +133,7 @@ string16 UninstallView::GetDialogButtonLabel(ui::DialogButton button) const {
void UninstallView::ButtonPressed(views::Button* sender,
const views::Event& event) {
- if (change_default_browser_ == sender) {
+ if (change_default_browser_ && change_default_browser_ == sender) {
// Disable the browsers combobox if the user unchecks the checkbox.
DCHECK(browsers_combo_);
browsers_combo_->SetEnabled(change_default_browser_->checked());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698