Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7099)

Unified Diff: chrome/installer/util/shell_util.h

Issue 10453041: Support for interactive set-chrome-as-default in Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/shell_util.h
diff --git a/chrome/installer/util/shell_util.h b/chrome/installer/util/shell_util.h
index 85e5fbd7d0f9e8123a5e2b2157810f3ad4ede95f..d0cf5b5c62c28f57470f2f67198199e1f565b3a7 100644
--- a/chrome/installer/util/shell_util.h
+++ b/chrome/installer/util/shell_util.h
@@ -237,6 +237,11 @@ class ShellUtil {
const string16& chrome_exe,
bool elevate_if_not_admin);
+ static bool ShowMakeChromeDefaultSystemUI(BrowserDistribution* dist,
+ int shell_change,
+ const string16& chrome_exe,
+ bool elevate_if_not_admin);
+
// Make Chrome the default application for a protocol.
// chrome_exe: The chrome.exe path to register as default browser.
// protocol: The protocol to register as the default handler for.
@@ -244,18 +249,18 @@ class ShellUtil {
const string16& chrome_exe,
const string16& protocol);
- // This method adds Chrome to the list that shows up in Add/Remove Programs->
- // Set Program Access and Defaults and also creates Chrome ProgIds under
- // Software\Classes. This method requires write access to HKLM so is just
- // best effort deal. If write to HKLM fails and elevate_if_not_admin is true,
- // this method will:
+ // This method registers Chrome with Windows (e.g., with "Set Program Access
+ // and Defaults" or "Default Programs", as an http protocol handler, etc.).
+ // This method requires write access to HKLM unless this is a user-level
+ // install on Windows 8 and above. If writing to HKLM fails and
+ // elevate_if_not_admin is true, this method will:
// - add the ProgId entries to HKCU on XP. HKCU entries will not make
// Chrome show in Set Program Access and Defaults but they are still useful
// because we can make Chrome run when user clicks on http link or html
// file.
- // - will try to launch setup.exe with admin priviledges on Vista to do
- // these tasks. Users will see standard Vista elevation prompt and if they
- // enter the right credentials, the write operation will work.
+ // - will try to launch setup.exe with admin privileges on Vista and above to
+ // do these tasks. Users will see the standard UAC prompt and if they enter
+ // the right credentials, the write operation will work.
// Currently elevate_if_not_admin is true only when user tries to make Chrome
// default browser (through the UI or through installer options) and Chrome
// is not registered on the machine.

Powered by Google App Engine
This is Rietveld 408576698