Support for interactive set-chrome-as-default in Windows.

chrome/browser/shell_integration_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/shell_integration.h"
 
 #include <windows.h>
 #include <shobjidl.h>
 #include <propkey.h>
 #include <propvarutil.h>
@@ skipping 371 matching lines @@
 
     if (kLocations[i].sub_dir)
       path = path.Append(kLocations[i].sub_dir);
 
     MigrateWin7ShortcutsInPath(chrome_exe, path);
   }
 }
 
 }  // namespace
 
-bool ShellIntegration::CanSetAsDefaultBrowser() {
-  return BrowserDistribution::GetDistribution()->CanSetAsDefault();
+ShellIntegration::DefaultSettingsChangePermission
+    ShellIntegration::CanSetAsDefaultBrowser() {
+  if (!BrowserDistribution::GetDistribution()->CanSetAsDefault()) {

[grt (UTC plus 2), 2012/05/25 20:27:38]

no braces for these one-liners

[motek., 2012/05/28 17:40:33]

Done.

+    return CHANGE_DEFAULT_NOT_ALLOWED;
+  }
+
+  if (base::win::GetVersion() >= base::win::VERSION_WIN8) {

[grt (UTC plus 2), 2012/05/25 20:27:38]

no braces for these

[motek., 2012/05/28 17:40:33]

Done.

+    return CHANGE_DEFAULT_INTERACTIVE;
+  } else {
+    return CHANGE_DEFAULT_UNATTENDED;
+  }
 }
 
 bool ShellIntegration::SetAsDefaultBrowser() {
   FilePath chrome_exe;
   if (!PathService::Get(base::FILE_EXE, &chrome_exe)) {
     LOG(ERROR) << "Error getting app exe path";
     return false;
   }
 
   // From UI currently we only allow setting default browser for current user.
@@ skipping 24 matching lines @@
         wprotocol)) {
     LOG(ERROR) << "Chrome could not be set as default handler for "
                << protocol << ".";
     return false;
   }
 
   VLOG(1) << "Chrome registered as default handler for " << protocol << ".";
   return true;
 }
 
+bool ShellIntegration::StartSetAsDefaultBrowserInteractive() {
+  FilePath chrome_exe;
+  if (!PathService::Get(base::FILE_EXE, &chrome_exe)) {
+    LOG(ERROR) << "Error getting app exe path";

[grt (UTC plus 2), 2012/05/25 20:27:38]

i think NOTREACHED(); or LOG(DFATAL) << ...; would be good here, since this
should never ever ever ever fail.

[motek., 2012/05/28 17:40:33]

Fair enough. I just copied&pasted this without giving it much thought. Done.

+    return false;
+  }
+
+  BrowserDistribution* dist = BrowserDistribution::GetDistribution();
+  if (!ShellUtil::ShowMakeChromeDefaultSystemUI(dist, ShellUtil::CURRENT_USER,
+                                                chrome_exe.value(), true)) {
+    LOG(ERROR) << "Failed to launch the set-default-browser Windows UI.";
+    return false;
+  }
+
+  VLOG(1) << "Set-as-default Windows UI triggered.";
+  return true;
+}
+
 ShellIntegration::DefaultWebClientState ShellIntegration::IsDefaultBrowser() {
   // When we check for default browser we don't necessarily want to count file
   // type handlers and icons as having changed the default browser status,
   // since the user may have changed their shell settings to cause HTML files
   // to open with a text editor for example. We also don't want to aggressively
   // claim FTP, since the user may have a separate FTP client. It is an open
   // question as to how to "heal" these settings. Perhaps the user should just
   // re-run the installer or run with the --set-default-browser command line
   // flag. There is doubtless some other key we can hook into to cause "Repair"
   // to show up in Add/Remove programs for us.
   static const wchar_t* const kChromeProtocols[] = { L"http", L"https" };
-

[grt (UTC plus 2), 2012/05/25 20:27:38]

nit: please add this newline back.  it was my favorite.

[motek., 2012/05/28 17:40:33]

Done.

   return ProbeProtocolHandlers(kChromeProtocols, arraysize(kChromeProtocols));
 }
 
 ShellIntegration::DefaultWebClientState
     ShellIntegration::IsDefaultProtocolClient(const std::string& protocol) {
   if (protocol.empty())
     return UNKNOWN_DEFAULT_WEB_CLIENT;
 
   string16 wide_protocol(UTF8ToUTF16(protocol));
   const wchar_t* const protocols[] = { wide_protocol.c_str() };
@@ skipping 70 matching lines @@
 }
 
 void ShellIntegration::MigrateChromiumShortcuts() {
   if (base::win::GetVersion() < base::win::VERSION_WIN7)
     return;
 
   BrowserThread::PostTask(
       BrowserThread::FILE, FROM_HERE,
       base::Bind(&MigrateChromiumShortcutsCallback));
 }