Debug crash in WebstoreInstaller::StartDownload()

chrome/browser/extensions/webstore_installer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/webstore_installer.h"
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/file_util.h"
@@ skipping 177 matching lines @@
   if (!Extension::IdIsValid(id_)) {
     ReportFailure(kInvalidIdError);
     return;
   }
 
   FilePath download_path = DownloadPrefs::FromDownloadManager(
       profile_->GetDownloadManager())->download_path();
   BrowserThread::PostTask(
       BrowserThread::FILE, FROM_HERE,
       base::Bind(&GetDownloadFilePath, download_path, id_,
-                 base::Bind(&WebstoreInstaller::StartDownload,
-                            base::Unretained(this))));
-
+                 base::Bind(&WebstoreInstaller::StartDownload, this)));
 }
 
 void WebstoreInstaller::Observe(int type,
                                 const content::NotificationSource& source,
                                 const content::NotificationDetails& details) {
   switch (type) {
     case chrome::NOTIFICATION_CRX_INSTALLER_DONE: {
       const Extension* extension =
           content::Details<const Extension>(details).ptr();
       CrxInstaller* installer = content::Source<CrxInstaller>(source).ptr();
@@ skipping 85 matching lines @@
   }
 }
 
 void WebstoreInstaller::OnDownloadOpened(DownloadItem* download) {
   CHECK_EQ(download_item_, download);
 }
 
 void WebstoreInstaller::StartDownload(const FilePath& file) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
-  if (file.empty()) {
+  if (file.empty() || !controller_ || !controller_->GetWebContents()) {

[Aaron Boodman, 2012/06/11 21:53:42]

How can controller_ be NULL?

[benjhayden, 2012/06/12 17:51:53]

Changed the c-tor to validate it. PTAL.

     ReportFailure(kDownloadDirectoryError);
     return;
   }
 
   content::DownloadSaveInfo save_info;
   save_info.file_path = file;
 
   // The download url for the given extension is contained in |download_url_|.
   // We will navigate the current tab to this url to start the download. The
   // download system will then pass the crx to the CrxInstaller.
   download_util::RecordDownloadSource(
       download_util::INITIATED_BY_WEBSTORE_INSTALLER);
   scoped_ptr<DownloadUrlParameters> params(
       DownloadUrlParameters::FromWebContents(
           controller_->GetWebContents(), download_url_, save_info));
-  params->set_referrer(
-      content::Referrer(controller_->GetActiveEntry()->GetURL(),
-                        WebKit::WebReferrerPolicyDefault));
+  if (controller_->GetActiveEntry())
+    params->set_referrer(
+        content::Referrer(controller_->GetActiveEntry()->GetURL(),
+                          WebKit::WebReferrerPolicyDefault));
   params->set_callback(base::Bind(&WebstoreInstaller::OnDownloadStarted, this));
   profile_->GetDownloadManager()->DownloadUrl(params.Pass());
 }
 
 void WebstoreInstaller::ReportFailure(const std::string& error) {
   if (delegate_) {
     delegate_->OnExtensionInstallFailure(id_, error);
     delegate_ = NULL;
   }
 
   Release();  // Balanced in Start().
 }
 
 void WebstoreInstaller::ReportSuccess() {
   if (delegate_) {
     delegate_->OnExtensionInstallSuccess(id_);
     delegate_ = NULL;
   }
 
   Release();  // Balanced in Start().
 }