Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Issue 10453013: Remove hit weight experiment (Closed)

Created:
8 years, 7 months ago by dominich
Modified:
8 years, 7 months ago
Reviewers:
cbentzel
CC:
chromium-reviews, tburkard+watch_chromium.org, cbentzel+watch_chromium.org, arv (Not doing code reviews), dominich+watch_chromium.org, mmenke
Visibility:
Public.

Description

Remove hit weight experiment. Results of the experiment show that higher hit weights yield greater coverage, but at the expense of accuracy. The decreased accuracy outweighs the increased coverage. BUG=111069 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139086

Patch Set 1 #

Patch Set 2 : integer math for the win #

Total comments: 4

Patch Set 3 : rebase #

Patch Set 4 : trying rebase again - missing base file? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -43 lines) Patch
M chrome/browser/predictors/autocomplete_action_predictor.h View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/predictors/autocomplete_action_predictor.cc View 1 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/prerender/prerender_field_trial.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M chrome/browser/prerender/prerender_histograms.cc View 3 chunks +3 lines, -8 lines 0 comments Download
M chrome/browser/resources/predictors/predictors.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/predictors/predictors_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
dominich
8 years, 7 months ago (2012-05-24 21:02:11 UTC) #1
cbentzel
LGTM http://codereview.chromium.org/10453013/diff/7001/chrome/browser/predictors/autocomplete_action_predictor.cc File chrome/browser/predictors/autocomplete_action_predictor.cc (left): http://codereview.chromium.org/10453013/diff/7001/chrome/browser/predictors/autocomplete_action_predictor.cc#oldcode245 chrome/browser/predictors/autocomplete_action_predictor.cc:245: StringPrintf("Prerender.OmniboxNavigationsCouldPrerender_%.1f%s", Do you plan to obsolete these in ...
8 years, 7 months ago (2012-05-25 16:34:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominich@chromium.org/10453013/7001
8 years, 7 months ago (2012-05-25 16:54:11 UTC) #3
dominich
https://chromiumcodereview.appspot.com/10453013/diff/7001/chrome/browser/predictors/autocomplete_action_predictor.cc File chrome/browser/predictors/autocomplete_action_predictor.cc (left): https://chromiumcodereview.appspot.com/10453013/diff/7001/chrome/browser/predictors/autocomplete_action_predictor.cc#oldcode245 chrome/browser/predictors/autocomplete_action_predictor.cc:245: StringPrintf("Prerender.OmniboxNavigationsCouldPrerender_%.1f%s", On 2012/05/25 16:34:34, cbentzel wrote: > Do you ...
8 years, 7 months ago (2012-05-25 16:54:56 UTC) #4
commit-bot: I haz the power
Try job failure for 10453013-7001 on linux_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=27564 Step "update" is always ...
8 years, 7 months ago (2012-05-25 17:00:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominich@chromium.org/10453013/9
8 years, 7 months ago (2012-05-25 17:09:01 UTC) #6
commit-bot: I haz the power
8 years, 7 months ago (2012-05-25 18:50:38 UTC) #7
Change committed as 139086

Powered by Google App Engine
This is Rietveld 408576698