Improve the UI for disabling off-store extension install.

chrome/browser/download/download_shelf_context_menu.cc

Index: chrome/browser/download/download_shelf_context_menu.cc
diff --git a/chrome/browser/download/download_shelf_context_menu.cc b/chrome/browser/download/download_shelf_context_menu.cc
index d73e3ef8bef1284e988ca8b5b64dcb4f0647eb58..a950017d2e4ce143d5d43716eadb2d04d8883262 100644
--- a/chrome/browser/download/download_shelf_context_menu.cc
+++ b/chrome/browser/download/download_shelf_context_menu.cc
@@ -53,15 +53,13 @@ bool DownloadShelfContextMenu::IsCommandIdEnabled(int command_id) const {
           !download_item_->IsTemporary();
     case OPEN_WHEN_COMPLETE:
       return download_item_->CanShowInFolder() &&
-          !download_item_->IsTemporary() &&
-          (!Extension::IsExtension(download_item_->GetTargetName()) ||
-           extensions::switch_utils::IsOffStoreInstallEnabled());
+          !download_item_->IsTemporary();

[asanka, 2012/05/25 18:28:18]

The confusingly named OPEN_WHEN_COMPLETE option means "Open when complete" while
DownloadItem::IsInProgress() and means "Open" after the download is complete.

It looks like you want the option to only be enabled if:

  download_item_->CanShowInFolder() &&
  !download_item_->IsTemporary() &&
  (!download_crx_util::IsExtensionDownload(*download_item_) ||
   download_item_->IsComplete())

(The '|| download_item->IsComplete()' part won't matter much since the download
item will disappear when the extension auto opens.)

     case ALWAYS_OPEN_TYPE:
       // For temporary downloads, the target filename might be a temporary
       // filename. Don't base an "Always open" decision based on it. Also
       // exclude extensions.
       return download_item_->CanOpenDownload() &&
-          !Extension::IsExtension(download_item_->GetTargetName()) &&
+          !download_crx_util::IsExtensionDownload(*download_item_) &&
           !download_item_->IsTemporary();
     case CANCEL:
       return download_item_->IsPartialDownload();