Improve the UI for disabling off-store extension install.

chrome/browser/download/download_history.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/download_history.h"
 
 #include "base/logging.h"
-#include "chrome/browser/download/chrome_download_manager_delegate.h"
+#include "chrome/browser/download/download_crx_util.h"
 #include "chrome/browser/history/history_marshaling.h"
 #include "chrome/browser/profiles/profile.h"
 #include "content/public/browser/download_item.h"
 #include "content/public/browser/download_persistent_store_info.h"
 
 using content::DownloadItem;
 using content::DownloadPersistentStoreInfo;
 
 DownloadHistory::DownloadHistory(Profile* profile)
     : profile_(profile),
@@ skipping 50 matching lines @@
   // - incognito mode (that is the point of this mode)
   // - extensions (users don't think of extension installation as 'downloading')
   // - temporary download, like in drag-and-drop
   // - history service is not available (e.g. in tests)
   // We have to make sure that these handles don't collide with normal db
   // handles, so we use a negative value. Eventually, they could overlap, but
   // you'd have to do enough downloading that your ISP would likely stab you in
   // the neck first. YMMV.
   HistoryService* hs = profile_->GetHistoryService(Profile::EXPLICIT_ACCESS);
   if (download_item->IsOtr() ||
-      ChromeDownloadManagerDelegate::IsExtensionDownload(download_item) ||
+      download_crx_util::IsExtensionDownload(*download_item) ||
       download_item->IsTemporary() || !hs) {
     callback.Run(download_item->GetId(), GetNextFakeDbHandle());
     return;
   }
 
   int32 id = download_item->GetId();
   DownloadPersistentStoreInfo history_info =
       download_item->GetPersistentStoreInfo();
   hs->CreateDownload(id, history_info, &history_consumer_, callback);
 }
@@ skipping 48 matching lines @@
                                             base::Time first_visit) {
   VisitedBeforeRequestsMap::iterator request =
       visited_before_requests_.find(handle);
   DCHECK(request != visited_before_requests_.end());
   int32 download_id = request->second.first;
   VisitedBeforeDoneCallback callback = request->second.second;
   visited_before_requests_.erase(request);
   callback.Run(download_id, found_visits && count &&
       (first_visit.LocalMidnight() < base::Time::Now().LocalMidnight()));
 }