Implement a heap profiler for the Dart managed heap.

runtime/vm/dart_api_impl.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/dart.h"
@@ skipping 590 matching lines @@
   if (!callbacks.Contains(callback)) {
     return Api::NewError(
         "%s expects 'callback' to be present in the epilogue callback list.",
         CURRENT_FUNC);
   }
   callbacks.Remove(callback);
   return Api::Success(isolate);
 }
 
 
+DART_EXPORT Dart_Handle Dart_HeapProfile(Dart_HeapProfileWriteCallback callback,
+                                         void* stream) {
+  if (callback == NULL) {
+    return Api::NewError("%s expects argument 'callback' to be non-null.",
+                         CURRENT_FUNC);
+  }
+  Isolate* isolate = Isolate::Current();
+  CHECK_ISOLATE(isolate);

[turnidge, 2012/05/29 17:50:01]

I would move the CHECK_ISOLATE above your callback == NULL check -- the call to
Api::NewError will fail if there is no current isolate.

[cshapiro, 2012/06/01 04:27:02]

I should have noticed that.  Done.

+  isolate->heap()->Profile(callback, stream);
+  return Api::Success(isolate);
+}
+
 // --- Initialization and Globals ---
 
 
 DART_EXPORT bool Dart_Initialize(Dart_IsolateCreateCallback create,
                                  Dart_IsolateInterruptCallback interrupt) {
   return Dart::InitOnce(create, interrupt);
 }
 
 DART_EXPORT bool Dart_SetVMFlags(int argc, const char** argv) {
   return Flags::ProcessCommandLineFlags(argc, argv);
@@ skipping 2692 matching lines @@
       *buffer = NULL;
     }
     delete debug_region;
   } else {
     *buffer = NULL;
     *buffer_size = 0;
   }
 }
 
 }  // namespace dart