Add GSM_MS and PCM_ALAW codecs to CrOS FFMPEG.

FFmpeg: Add gsm_ms and pcm big endian codecs.

Also update corresponding tests.

BUG=chromium-os:31955
TEST=Played on linux CrOS build.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150154

[DaleCurtis, 2012-07-25 18:22:14]

Working on the ffmpeg portion of this now.

http://codereview.chromium.org/10452004/diff/8001/content/browser/media_brows...
File content/browser/media_browsertest.cc (right):

http://codereview.chromium.org/10452004/diff/8001/content/browser/media_brows...
content/browser/media_browsertest.cc:99: PlayVideo("bear_gsm_ms.wav");
PlayAudio?

http://codereview.chromium.org/10452004/diff/8001/content/browser/media_brows...
content/browser/media_browsertest.cc:107: PlayAudio("bear_pcm_s16be.mov");
PlayVideo? Why .mov instead of .wav files? Also I'm thinking we should enable
the be variants for all of chromium, not just ChromeOS.

http://codereview.chromium.org/10452004/diff/8001/media/base/audio_decoder_co...
File media/base/audio_decoder_config.h (right):

http://codereview.chromium.org/10452004/diff/8001/media/base/audio_decoder_co...
media/base/audio_decoder_config.h:29: kCodecGSM_MS,
I think you need to put this at the end otherwise you'll mess up existing UMA
stats.

[DaleCurtis, 2012-07-25 18:25:08]

On 2012/07/25 18:22:14, DaleCurtis wrote:
> Working on the ffmpeg portion of this now.
> 
>
http://codereview.chromium.org/10452004/diff/8001/content/browser/media_brows...
> File content/browser/media_browsertest.cc (right):
> 
>
http://codereview.chromium.org/10452004/diff/8001/content/browser/media_brows...
> content/browser/media_browsertest.cc:99: PlayVideo("bear_gsm_ms.wav");
> PlayAudio?
> 
>
http://codereview.chromium.org/10452004/diff/8001/content/browser/media_brows...
> content/browser/media_browsertest.cc:107: PlayAudio("bear_pcm_s16be.mov");
> PlayVideo? Why .mov instead of .wav files? Also I'm thinking we should enable
> the be variants for all of chromium, not just ChromeOS.
> 
>
http://codereview.chromium.org/10452004/diff/8001/media/base/audio_decoder_co...
> File media/base/audio_decoder_config.h (right):
> 
>
http://codereview.chromium.org/10452004/diff/8001/media/base/audio_decoder_co...
> media/base/audio_decoder_config.h:29: kCodecGSM_MS,
> I think you need to put this at the end otherwise you'll mess up existing UMA
> stats.

Also, I believe the data files are moving to content via:
http://codereview.chromium.org/10828015/

[ilja, 2012-07-25 20:09:36]

Adding Chris for a security review.

https://chromiumcodereview.appspot.com/10452004/diff/8001/content/browser/med...
File content/browser/media_browsertest.cc (right):

https://chromiumcodereview.appspot.com/10452004/diff/8001/content/browser/med...
content/browser/media_browsertest.cc:99: PlayVideo("bear_gsm_ms.wav");
Guilty of copy and pasting.

https://chromiumcodereview.appspot.com/10452004/diff/8001/content/browser/med...
content/browser/media_browsertest.cc:107: PlayAudio("bear_pcm_s16be.mov");
On 2012/07/25 18:22:14, DaleCurtis wrote:
> PlayVideo? Why .mov instead of .wav files?

FFmpeg refuses to encode into big endian wav files. I could not find any samples
online. Remember we encountered them inside of the skydiving video. But we
should check with rbultje.

> Also I'm thinking we should enable
> the be variants for all of chromium, not just ChromeOS.

The skydiving video was a video that did not play on Chrome but on CrOS. (The
link is dead unfortunately.) If there is a way to encounter this variant in
Chrome I agree we should enable it there.

https://chromiumcodereview.appspot.com/10452004/diff/8001/media/base/audio_de...
File media/base/audio_decoder_config.h (right):

https://chromiumcodereview.appspot.com/10452004/diff/8001/media/base/audio_de...
media/base/audio_decoder_config.h:29: kCodecGSM_MS,
On 2012/07/25 18:22:14, DaleCurtis wrote:
> I think you need to put this at the end otherwise you'll mess up existing UMA
> stats.

Done.

[DaleCurtis, 2012-07-26 20:04:57]

LGTM, FTR the new GSM codec files can be found under libavcodec/gsm*, ~550 new
lines of code are enabled from FFmpeg.

[commit-bot: I haz the power, 2012-07-29 19:55:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ihf@chromium.org/10452004/14002

[commit-bot: I haz the power, 2012-07-29 19:55:03]

Failed to apply patch for chrome/test/data/media/bear_gsmms.wav:
While running svn delete chrome/test/data/media/bear_gsmms.wav --force
--config-dir /b/commit-queue/subversion_config --non-interactive;
svn: 'chrome/test/data/media/bear_gsmms.wav' does not exist

[ilja, 2012-07-29 21:41:50]

I split off the binaries to the new location
https://chromiumcodereview.appspot.com/10835028/
and rebased the change.

[DaleCurtis, 2012-07-29 23:25:53]

On 2012/07/29 21:41:50, ilja wrote:
> I split off the binaries to the new location
> https://chromiumcodereview.appspot.com/10835028/
> and rebased the change.

The FFMpeg roll hasn't landed yet, so don't CQ this yet.  Additionally scherkus
and cevans might have comments :)

[ilja, 2012-08-04 00:46:46]

Scherkus: Chris was fine and Josh Woodward told me it was went through the
meeting and I should not worry the last aspect of the shepherding. Can I land
this now?

[scherkus (not reviewing), 2012-08-04 00:57:28]

sgtm!
On Aug 3, 2012 5:46 PM, <ihf@chromium.org> wrote:

> Scherkus: Chris was fine and Josh Woodward told me it was went through the
> meeting and I should not worry the last aspect of the shepherding. Can I
> land
> this now?
>
>
http://codereview.chromium.**org/10452004/<http://codereview.chromium.org/104...
>

[commit-bot: I haz the power, 2012-08-04 04:49:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ihf@chromium.org/10452004/21001

[commit-bot: I haz the power, 2012-08-04 04:49:50]

Presubmit check for 10452004-21001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content/browser

[ilja, 2012-08-04 04:52:41]

sky - please owner review!

[sky, 2012-08-06 14:46:46]

LGTM

[commit-bot: I haz the power, 2012-08-06 18:47:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ihf@chromium.org/10452004/21001

[commit-bot: I haz the power, 2012-08-06 21:49:56]

Change committed as 150154