content/renderer/media/video_capture_impl.cc - Issue 10451087: for readability review.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/video_capture_impl.cc

Issue 10451087: for readability review. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/video_capture_impl.cc

===================================================================

--- content/renderer/media/video_capture_impl.cc (revision 139637)

+++ content/renderer/media/video_capture_impl.cc (working copy)

@@ -23,7 +23,7 @@

scoped_ptr<base::SharedMemory> dib;

scoped_refptr<media::VideoCapture::VideoFrameBuffer> mapped_memory;

- // Number of clients which hold this DIB.

+ // Number of clients which hold this DIB.

int references;

zunger 2012/07/09 20:08:26 Are you sure you want to use an unlocked int for a

wjia(left Chromium) 2012/07/10 17:32:28 Yes, DIBBuffer's are accessed only on capture thre

};