for readability review.

content/renderer/media/video_capture_impl_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/message_loop.h"
 #include "content/common/media/video_capture_messages.h"
 #include "content/renderer/media/video_capture_impl.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using ::testing::_;
 using ::testing::AtLeast;
 using ::testing::Return;
 
 #define CAPABILITY_SMALL {176, 144, 30, media::VideoCaptureCapability::kI420, \
     0, false }
 #define CAPABILITY_LARGE {320, 240, 30, media::VideoCaptureCapability::kI420, \
     0, false }
 
 class MockVideoCaptureMessageFilter : public VideoCaptureMessageFilter {
  public:
   MockVideoCaptureMessageFilter() : VideoCaptureMessageFilter() {}
 
-  // Filter implementation.
+  // Filter  implementation.
   MOCK_METHOD1(Send, bool(IPC::Message* message));
 
  protected:
   virtual ~MockVideoCaptureMessageFilter() {}
 
  private:
   DISALLOW_COPY_AND_ASSIGN(MockVideoCaptureMessageFilter);
 };
 
 class MockVideoCaptureClient : public media::VideoCapture::EventHandler {
@@ skipping 29 matching lines @@
     }
     virtual ~MockVideoCaptureImpl() {}
 
     // Override Send() to mimic device to send events.
     void Send(IPC::Message* message) {
       CHECK(message);
 
       // In this method, messages are sent to the according handlers as if
       // we are the device.
       bool handled = true;
       IPC_BEGIN_MESSAGE_MAP(MockVideoCaptureImpl, *message)

[zunger, 2012/07/09 20:08:26]

Do these helpers not want trailing semicolons for some reason?

[wjia(left Chromium), 2012/07/10 17:32:28]

That macro has a trailing semicolon. Please refer to
http://src.chromium.org/viewvc/chrome/trunk/src/ipc/ipc_message_macros.h?cont...

         IPC_MESSAGE_HANDLER(VideoCaptureHostMsg_Start, DeviceStartCapture)
         IPC_MESSAGE_HANDLER(VideoCaptureHostMsg_Pause, DevicePauseCapture)
         IPC_MESSAGE_HANDLER(VideoCaptureHostMsg_Stop, DeviceStopCapture)
         IPC_MESSAGE_HANDLER(VideoCaptureHostMsg_BufferReady,
                             DeviceReceiveEmptyBuffer)
         IPC_MESSAGE_UNHANDLED(handled = false)
       IPC_END_MESSAGE_MAP()
       EXPECT_TRUE(handled);
       delete message;
     }
@@ skipping 201 matching lines @@
       .WillOnce(Return());
   EXPECT_CALL(*client2, OnStopped(_))
       .WillOnce(Return());
   EXPECT_CALL(*client2, OnRemoved(_))
       .WillOnce(Return());
 
   video_capture_impl_->StopCapture(client1.get());
   video_capture_impl_->StopCapture(client2.get());
   message_loop_->RunAllPending();
 }