Adding UMA for sync IPCs

content/renderer/renderer_webkitplatformsupport_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/renderer_webkitplatformsupport_impl.h"
 
 #include "base/command_line.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/platform_file.h"
@@ skipping 155 matching lines @@
       sandbox_support_(new RendererWebKitPlatformSupportImpl::SandboxSupport),
       sudden_termination_disables_(0),
       shared_worker_repository_(new WebSharedWorkerRepositoryImpl) {
 }
 
 RendererWebKitPlatformSupportImpl::~RendererWebKitPlatformSupportImpl() {
 }
 
 //------------------------------------------------------------------------------
 
+namespace {
+
+bool SendSyncMessageFromAnyThreadInternal(IPC::SyncMessage* msg) {
+  RenderThreadImpl* render_thread = RenderThreadImpl::current();
+  if (render_thread)
+    return render_thread->Send(msg);
+  scoped_refptr<IPC::SyncMessageFilter> sync_msg_filter(
+      ChildThread::current()->sync_message_filter());
+  return sync_msg_filter->Send(msg);
+}
+
+bool SendSyncMessageFromAnyThread(IPC::SyncMessage* msg) {
+  base::TimeTicks begin = base::TimeTicks::Now();
+  const bool success = SendSyncMessageFromAnyThread(msg);
+  base::TimeDelta delta = base::TimeTicks::Now() - begin;
+  ChildThread::current()->Send(new ViewHostMsg_SyncIPCElapsedTime(delta));

[jam, 2012/05/31 15:20:16]

you can histogram from the renderer, just call HISTOGRAM_TIMES here

[kinuko, 2012/05/31 17:10:36]

oooops... (ashamed) done.

+  return success;
+}
+
+}  // namespace
+
 WebKit::WebClipboard* RendererWebKitPlatformSupportImpl::clipboard() {
   return clipboard_.get();
 }
 
 WebKit::WebMimeRegistry* RendererWebKitPlatformSupportImpl::mimeRegistry() {
   return mime_registry_.get();
 }
 
 WebKit::WebFileUtilities*
 RendererWebKitPlatformSupportImpl::fileUtilities() {
@@ skipping 22 matching lines @@
   // As explained in WebKitPlatformSupport.h, this function is used to decide
   // whether to allow file system operations to come out of WebKit or not.
   // Even if the sandbox is disabled, there's no reason why the code should
   // act any differently...unless we're in single process mode.  In which
   // case, we have no other choice.  WebKitPlatformSupport.h discourages using
   // this switch unless absolutely necessary, so hopefully we won't end up
   // with too many code paths being different in single-process mode.
   return !CommandLine::ForCurrentProcess()->HasSwitch(switches::kSingleProcess);
 }
 
-bool RendererWebKitPlatformSupportImpl::SendSyncMessageFromAnyThread(
-    IPC::SyncMessage* msg) {
-  RenderThreadImpl* render_thread = RenderThreadImpl::current();
-  if (render_thread)
-    return render_thread->Send(msg);
-
-  scoped_refptr<IPC::SyncMessageFilter> sync_msg_filter(
-      ChildThread::current()->sync_message_filter());
-  return sync_msg_filter->Send(msg);
-}
-
 unsigned long long RendererWebKitPlatformSupportImpl::visitedLinkHash(
     const char* canonical_url,
     size_t length) {
   return content::GetContentClient()->renderer()->VisitedLinkHash(
       canonical_url, length);
 }
 
 bool RendererWebKitPlatformSupportImpl::isLinkVisited(
     unsigned long long link_hash) {
   return content::GetContentClient()->renderer()->IsLinkVisited(link_hash);
@@ skipping 465 matching lines @@
   DCHECK(render_thread);
   if (!render_thread)
     return NULL;
   return render_thread->CreateMediaStreamCenter(client);
 }
 
 GpuChannelHostFactory*
 RendererWebKitPlatformSupportImpl::GetGpuChannelHostFactory() {
   return RenderThreadImpl::current();
 }