sync: move invalidation version prefs out of SyncPrefs into InvalidatorStorage.

chrome/browser/sync/invalidations/invalidator_storage_unittest.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+//
+
+#include "chrome/browser/sync/invalidations/invalidator_storage.h"
+
+#include "base/message_loop.h"
+#include "chrome/test/base/testing_pref_service.h"
+#include "sync/syncable/model_type.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace browser_sync {
+
+class InvalidatorStorageTest : public testing::Test {

[rlarocque, 2012/05/29 18:28:24]

I'd like to see some tests for the parsing code.  There are a few scenarios that
probably should be covered, ie. an empty dictionary or invalid model types.  

It doesn't have to be implemented in this patch, but it would be nice to have
eventually.  

[tim (not reviewing), 2012/05/29 23:17:31]

Get and Set actually deserialize and serialize from/to the pref format, so
MaxInvalidationVersions does actually hit the parsing code for the happy case,
but I've added more targeted tests for that and edge cases.

+ protected:
+  TestingPrefService pref_service_;
+
+ private:
+  MessageLoop loop_;
+};
+
+TEST_F(InvalidatorStorageTest, MaxInvalidationVersions) {
+  InvalidatorStorage storage(&pref_service_);
+
+  sync_notifier::InvalidationVersionMap expected_max_versions;
+  EXPECT_EQ(expected_max_versions, storage.GetAllMaxVersions());
+
+  expected_max_versions[syncable::BOOKMARKS] = 2;
+  storage.SetMaxVersion(syncable::BOOKMARKS, 2);
+  EXPECT_EQ(expected_max_versions, storage.GetAllMaxVersions());
+
+  expected_max_versions[syncable::PREFERENCES] = 5;
+  storage.SetMaxVersion(syncable::PREFERENCES, 5);
+  EXPECT_EQ(expected_max_versions, storage.GetAllMaxVersions());
+
+  expected_max_versions[syncable::APP_NOTIFICATIONS] = 3;
+  storage.SetMaxVersion(syncable::APP_NOTIFICATIONS, 3);
+  EXPECT_EQ(expected_max_versions, storage.GetAllMaxVersions());
+
+  expected_max_versions[syncable::APP_NOTIFICATIONS] = 4;
+  storage.SetMaxVersion(syncable::APP_NOTIFICATIONS, 4);
+  EXPECT_EQ(expected_max_versions, storage.GetAllMaxVersions());
+}
+
+TEST_F(InvalidatorStorageTest, Clear) {
+  InvalidatorStorage storage(&pref_service_);
+  EXPECT_TRUE(storage.GetAllMaxVersions().empty());
+  EXPECT_TRUE(storage.GetInvalidationState().empty());
+
+  storage.SetInvalidationState("test");
+  EXPECT_EQ("test", storage.GetInvalidationState());
+  {
+    sync_notifier::InvalidationVersionMap expected_max_versions;
+    expected_max_versions[syncable::APP_NOTIFICATIONS] = 3;
+    storage.SetMaxVersion(syncable::APP_NOTIFICATIONS, 3);
+    EXPECT_EQ(expected_max_versions, storage.GetAllMaxVersions());
+  }
+
+  storage.Clear();
+
+  EXPECT_TRUE(storage.GetAllMaxVersions().empty());
+  EXPECT_TRUE(storage.GetInvalidationState().empty());
+}
+
+TEST_F(InvalidatorStorageTest, NullPrefService) {
+  InvalidatorStorage storage(NULL);
+  EXPECT_TRUE(storage.GetAllMaxVersions().empty());
+  EXPECT_TRUE(storage.GetInvalidationState().empty());
+}
+
+}  // namespace browser_sync