Avoid double calling OnResponseStarted from BufferedResourceHandler

content/browser/renderer_host/buffered_resource_handler.cc

Index: content/browser/renderer_host/buffered_resource_handler.cc
diff --git a/content/browser/renderer_host/buffered_resource_handler.cc b/content/browser/renderer_host/buffered_resource_handler.cc
index b0de440f1be276bc8369fa386f3c2ca052be6ebd..0c01f6f93f97de0e1a5444c1afdebbd4d80826fa 100644
--- a/content/browser/renderer_host/buffered_resource_handler.cc
+++ b/content/browser/renderer_host/buffered_resource_handler.cc
@@ -281,8 +281,7 @@ bool BufferedResourceHandler::CompleteResponseStarted(int request_id,
         new X509UserCertResourceHandler(request_,
                                         info->GetChildID(),
                                         info->GetRouteID());
-    if (!UseAlternateResourceHandler(request_id, x509_cert_handler, defer))
-      return false;
+    return UseAlternateResourceHandler(request_id, x509_cert_handler, defer);
   } else if (info->allow_download() && ShouldDownload(NULL)) {

[darin (slow to review), 2012/05/25 21:24:34]

thanks to the unconditional return above, you can remove this else.

[Randy Smith (Not in Mondays), 2012/05/28 03:07:03]

Done.

     // Forward the data to the download thread.
 
@@ -310,8 +309,7 @@ bool BufferedResourceHandler::CompleteResponseStarted(int request_id,
             DownloadSaveInfo(),
             DownloadResourceHandler::OnStartedCallback()));
 
-    if (!UseAlternateResourceHandler(request_id, handler, defer))
-      return false;
+    return UseAlternateResourceHandler(request_id, handler, defer);
   }
 
   if (*defer)