chrome/browser/resources/print_preview/previewarea/margin_control.js - Issue 10450022: Print Preview Print Destination Search Widget

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/previewarea/margin_control.js

Issue 10450022: Print Preview Print Destination Search Widget (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fixes types in jsdoc. Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/print_preview/preview_generator.js ('k') | chrome/browser/resources/print_preview/previewarea/margin_control_container.js » ('j') | chrome/browser/resources/print_preview/search/destination_list_item.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/previewarea/margin_control.js

diff --git a/chrome/browser/resources/print_preview/previewarea/margin_control.js b/chrome/browser/resources/print_preview/previewarea/margin_control.js

index 476371a1805ab2f93fdd890dd9f7cc772c9b09cf..83fec087891aec0a1036319f894e49c4d25a00cb 100644

--- a/chrome/browser/resources/print_preview/previewarea/margin_control.js

+++ b/chrome/browser/resources/print_preview/previewarea/margin_control.js

@@ -7,7 +7,7 @@ cr.define('print_preview', function() {

/**

* Draggable control for setting a page margin.

- * @param {print_preview.ticket_items.CustomMargins.Orientation} orientation

+ * @param {!print_preview.ticket_items.CustomMargins.Orientation} orientation

* Orientation of the margin control that determines where the margin

* textbox will be placed.

* @constructor

@@ -18,7 +18,7 @@ cr.define('print_preview', function() {

/**

* Determines where the margin textbox will be placed.

- * @type {print_preview.ticket_items.CustomMargins.Orientation}

+ * @type {!print_preview.ticket_items.CustomMargins.Orientation}

* @private

this.orientation_ = orientation;

@@ -140,9 +140,9 @@ cr.define('print_preview', function() {

/**

* Map from orientation to CSS class name.

- * @type {object.<

- * print_preview.ticket_items.CustomMargins.Orientation,

- * MarginControl.Classes_>}

+ * @type {!Object.<

+ * !print_preview.ticket_items.CustomMargins.Orientation,

+ * !MarginControl.Classes_>}

* @private

MarginControl.OrientationToClass_ = {};

@@ -185,7 +185,7 @@ cr.define('print_preview', function() {

/**

- * @return {print_preview.ticket_items.CustomMargins.Orientation}

+ * @return {!print_preview.ticket_items.CustomMargins.Orientation}

* Orientation of the margin control.

getOrientation: function() {