Print Preview Print Destination Search Widget

chrome/browser/resources/print_preview/search/destination_list_item.css

+/* Copyright (c) 2012 The Chromium Authors. All rights reserved.
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.

[Dan Beam, 2012/05/29 21:25:50]

optional nit: in general I prefer not letting this */ hang over as it saves a
line and a byte

[Robert Toscano, 2012/05/29 22:17:36]

Done.

+ */
+
+.destination-list-item {
+  -webkit-transition: background-color 150ms;
+  cursor: default;
+  padding: 3px 2px 3px 18px;

[Dan Beam, 2012/05/29 21:25:50]

does this work in RTL? seems like you'd wanna do:

  -webkit-padding-end: 2px;
  -webkit-padding-start: 18px;
  padding-bottom: 3px;
  padding-top: 3px;

unless this is not affected by text direction.

[Robert Toscano, 2012/05/29 22:17:36]

There are a few other things that need to change. Like the icon should be on the
right instead of the left. How far should we support RTL? I can understand
changing text layout direction, but it seems like we would also need to change
icon layout. Should this be done in this CL?

[Dan Beam, 2012/05/29 22:30:18]

Supporting RTL means having a reasonable look in right-to-left text directions
(e.g. Hebrew, Arabic). If you make all the padding/margins LTR only it won't
look reasonable / right. Have you tried launching chrome with LANGUAGE=ar or
LANGUAGE=he (if using Linux)?

[Robert Toscano, 2012/05/30 21:08:00]

Done.

+}
+
+.destination-list-item:hover {
+  background-color: rgb(228, 236, 247);
+}
+
+.destination-list-item-icon {
+  -webkit-transition: opacity 150ms;
+  display: inline-block;
+  height: 24px;
+  margin-right: 8px;

[Dan Beam, 2012/05/29 21:25:50]

same question about RTL

[Robert Toscano, 2012/05/30 21:08:00]

Done.

+  opacity: .4;

[Dan Beam, 2012/05/29 21:25:50]

optional nit: I don't think we have an explicit rule either way, but most of the
code that I've seen in webui has 0.X rather than .X. If print_preview's local
style disagrees, follow it, otherwise you may want to s/.4/0.4/

[Robert Toscano, 2012/05/29 22:17:36]

It looks like its not entirely consistent. I've found some .X in
shared/css/tree.css and shared/css/widgets.css. Also if we're concerned about
conserving bytes (as your comment about copyright comment shows) maybe we should
strip the leading 0.

[Dan Beam, 2012/05/29 23:36:09]

I'd argue that 90% of these values being [0-9]\.[0-9]+ vs. \.[0-9]+ would be
enough, but like I said - optional.

[Robert Toscano, 2012/05/30 21:08:00]

Done.

+  vertical-align: middle;
+  width: 24px;
+}
+
+.destination-list-item:hover .destination-list-item-icon {
+  opacity: 1;
+}
+
+.destination-list-item-name {
+  vertical-align: middle;
+}