chrome/browser/resources/print_preview/search/destination_list.html - Issue 10450022: Print Preview Print Destination Search Widget

Side by Side Diff: chrome/browser/resources/print_preview/search/destination_list.html

Issue 10450022: Print Preview Print Destination Search Widget (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Address comments round 2 Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/print_preview/search/destination_list.css ('K') | « chrome/browser/resources/print_preview/search/destination_list.css ('k') | chrome/browser/resources/print_preview/search/destination_list.js » ('j') | chrome/browser/resources/print_preview/search/destination_list_item.css » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <div id="destination-list-template" style="display: none;">
	Dan Beam 2012/05/29 21:25:50 s/style="display: none;"/hidden/ s/style="display: none;"/hidden/ Robert Toscano 2012/05/29 22:17:36 These are different. "hidden" will render the elem Show quoted text On 2012/05/29 21:25:50, Dan Beam wrote: > s/style="display: none;"/hidden/ These are different. "hidden" will render the element hidden, but it still will have an effect on the DOM element layout. display=none will be like if the element wasn't even in the DOM tree. Dan Beam 2012/05/29 22:30:18 [hidden] is just display: none; but from user-agen Show quoted text On 2012/05/29 22:17:36, rltoscano wrote: > On 2012/05/29 21:25:50, Dan Beam wrote: > > s/style="display: none;"/hidden/ > > These are different. "hidden" will render the element hidden, but it still will > have an effect on the DOM element layout. display=none will be like if the > element wasn't even in the DOM tree. [hidden] is just display: none; but from user-agent styles (whereas this code is more of the "application level"). Just in case it was ambiguous, I meant: <div id="destination-list-template" hidden> It's the same thing, I promise. [hidden] is not visibility: hidden;. Additionally, I think you meant "render tree" not DOM tree, as you can still use the DOM/BOM to reference / affect [hidden]/display: none; nodes, it just usually isn't necessary. Robert Toscano 2012/05/30 21:08:00 Sorry, I thought "hidden" = "visibility: hidden". Show quoted text On 2012/05/29 22:30:18, Dan Beam wrote: > On 2012/05/29 22:17:36, rltoscano wrote: > > On 2012/05/29 21:25:50, Dan Beam wrote: > > > s/style="display: none;"/hidden/ > > > > These are different. "hidden" will render the element hidden, but it still > will > > have an effect on the DOM element layout. display=none will be like if the > > element wasn't even in the DOM tree. > > [hidden] is just display: none; but from user-agent styles (whereas this code is > more of the "application level"). Just in case it was ambiguous, I meant: > > <div id="destination-list-template" hidden> > > It's the same thing, I promise. [hidden] is not visibility: hidden;. > > Additionally, I think you meant "render tree" not DOM tree, as you can still use > the DOM/BOM to reference / affect [hidden]/display: none; nodes, it just usually > isn't necessary. Sorry, I thought "hidden" = "visibility: hidden". Thanks for the tip! And yea, I meant "render tree".
	2 <header class="destination-list-header">

	3 <h4 class="destination-list-title"></h4>

	4 <button class="destination-list-action-link link-button"></button>

	5 </header>

	6 <ul class="destination-list-destination-list-item-container"></ul>

	7 <div class="destination-list-no-destinations-message"

	8 i18n-content="noDestinationsMessage"></div>

	9 <footer class="destination-list-footer" style="display: none;">

	10 <button class="destination-list-show-all-button"

	11 i18n-content="showAllButtonText"></button>

	12 <span class="destination-list-total"></span>

	13 </footer>

	14 </div>

OLD	NEW