Use shadow DOM API to show icon for password generation.

chrome/renderer/autofill/password_generation_manager_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/common/autofill_messages.h"
 #include "chrome/renderer/autofill/password_generation_manager.h"
 #include "chrome/test/base/chrome_render_view_test.h"
@@ skipping 19 matching lines @@
   // Make this public
   virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE {
     return PasswordGenerationManager::OnMessageReceived(message);
   }
 
   const std::vector<IPC::Message*>& messages() {
     return messages_.get();
   }
 
  protected:
-  virtual bool ShouldAnalyzeFrame(const WebKit::WebFrame& frame) const
+  virtual bool ShouldAnalyzeDocument(const WebKit::WebDocument& document) const
       OVERRIDE {
     return true;
   }
 
   virtual bool Send(IPC::Message* message) OVERRIDE {
     messages_.push_back(message);
     return true;
   }
 
  private:
   ScopedVector<IPC::Message> messages_;
 
   DISALLOW_COPY_AND_ASSIGN(TestPasswordGenerationManager);
 };
 
 class PasswordGenerationManagerTest : public ChromeRenderViewTest {
  public:
   PasswordGenerationManagerTest() {}
 
   virtual void SetUp() {
     // We don't actually create a PasswordGenerationManager during
     // ChromeRenderViewTest::SetUp because it's behind a flag. Since we want
     // to use a test manager anyway, we just create out own.
     ChromeRenderViewTest::SetUp();
     generation_manager_.reset(new TestPasswordGenerationManager(view_));
   }
 
+  void SimulateClickOnDecoration(WebKit::WebInputElement& input_element) {
+    WebKit::WebElement decoration =
+        input_element.decorationElementFor(generation_manager_.get());
+    decoration.simulateClick();
+  }
+
  protected:
   scoped_ptr<TestPasswordGenerationManager> generation_manager_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(PasswordGenerationManagerTest);
 };
 
 const char kSigninFormHTML[] =
     "<FORM name = 'blah' action = 'http://www.random.com/'> "
     "  <INPUT type = 'text' id = 'username'/> "
@@ skipping 10 matching lines @@
     "</FORM>";
 
 TEST_F(PasswordGenerationManagerTest, DetectionTest) {
   LoadHTML(kSigninFormHTML);
 
   WebDocument document = GetMainFrame()->document();
   WebElement element =
       document.getElementById(WebString::fromUTF8("password"));
   ASSERT_FALSE(element.isNull());
   WebInputElement password_element = element.to<WebInputElement>();
-  EXPECT_EQ(0u, generation_manager_->messages().size());
+  EXPECT_FALSE(password_element.decorationElementFor(
+      generation_manager_.get()).hasNonEmptyBoundingBox());

[Ilya Sherman, 2012/06/01 00:34:31]

nit: This condition is somewhat lengthy -- perhaps worth decomposing a wrapper
method for it?

[Garrett Casto, 2012/06/01 01:21:28]

Done.

 
   LoadHTML(kAccountCreationFormHTML);
 
-  // We don't do anything yet because the feature is disabled.
+  // We don't show the decoration yet because the feature isn't enabled.
   document = GetMainFrame()->document();
   element = document.getElementById(WebString::fromUTF8("first_password"));
   ASSERT_FALSE(element.isNull());
   WebInputElement first_password_element = element.to<WebInputElement>();
-  EXPECT_EQ(0u, generation_manager_->messages().size());
   element = document.getElementById(WebString::fromUTF8("second_password"));
   ASSERT_FALSE(element.isNull());
   WebInputElement second_password_element = element.to<WebInputElement>();
-  EXPECT_EQ(0u, generation_manager_->messages().size());
-  SetFocused(first_password_element.to<WebNode>());
-  EXPECT_EQ(0u, generation_manager_->messages().size());
+  EXPECT_FALSE(first_password_element.decorationElementFor(
+      generation_manager_.get()).hasNonEmptyBoundingBox());

[Ilya Sherman, 2012/06/01 00:34:31]

nit: Hmm, shouldn't there be an EXPECT_TRUE with this same condition somewhere
further along in the test?

[Garrett Casto, 2012/06/01 01:21:28]

Yep, fixed.

 
   // Pretend like password generation was enabled.
   AutofillMsg_PasswordGenerationEnabled msg(0, true);
   generation_manager_->OnMessageReceived(msg);
 
-  // Now we will send a message once the first password feld is focused.
+  // Now check that the decoration is visible on the first password field and
+  // that we send a message after the decoration is clicked.
   LoadHTML(kAccountCreationFormHTML);
   document = GetMainFrame()->document();
   element = document.getElementById(WebString::fromUTF8("first_password"));
   ASSERT_FALSE(element.isNull());
   first_password_element = element.to<WebInputElement>();
   EXPECT_EQ(0u, generation_manager_->messages().size());
   element = document.getElementById(WebString::fromUTF8("second_password"));
   ASSERT_FALSE(element.isNull());
   second_password_element = element.to<WebInputElement>();
   EXPECT_EQ(0u, generation_manager_->messages().size());
-  SetFocused(first_password_element.to<WebNode>());
+  SimulateClickOnDecoration(first_password_element);
   EXPECT_EQ(1u, generation_manager_->messages().size());
   EXPECT_EQ(AutofillHostMsg_ShowPasswordGenerationPopup::ID,
             generation_manager_->messages()[0]->type());
 }
 
 TEST_F(PasswordGenerationManagerTest, FillTest) {
   // Make sure that we are enabled before loading HTML.
   AutofillMsg_PasswordGenerationEnabled enabled_msg(0, true);
   generation_manager_->OnMessageReceived(enabled_msg);
   LoadHTML(kAccountCreationFormHTML);
@@ skipping 16 matching lines @@
   generation_manager_->OnMessageReceived(msg);
 
   // Password fields are filled out and set as being autofilled.
   EXPECT_EQ(password, first_password_element.value());
   EXPECT_EQ(password, second_password_element.value());
   EXPECT_TRUE(first_password_element.isAutofilled());
   EXPECT_TRUE(second_password_element.isAutofilled());
 }
 
 }  // namespace autofill