content/test/render_view_fake_resources_test.cc - Issue 10449094: Fix client-side phishing detection test flakiness and ChromeOS failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/render_view_fake_resources_test.cc

Issue 10449094: Fix client-side phishing detection test flakiness and ChromeOS failure. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Generalize the fix and apply it to webrtc_audio_device_test Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/test/render_view_fake_resources_test.cc

diff --git a/content/test/render_view_fake_resources_test.cc b/content/test/render_view_fake_resources_test.cc

index 9b2d540af4487be16f071239ba0a9de662c67143..deabd329660547ff23cf621dd97105c0aaba4967 100644

--- a/content/test/render_view_fake_resources_test.cc

+++ b/content/test/render_view_fake_resources_test.cc

@@ -12,8 +12,8 @@

#include "content/common/resource_messages.h"

#include "content/common/view_messages.h"

#include "content/public/common/resource_response.h"

-#include "content/renderer/render_thread_impl.h"

#include "content/renderer/render_view_impl.h"

+#include "content/test/render_test_utils.h"

#include "content/test/mock_render_process.h"

#include "googleurl/src/gurl.h"

#include "net/base/upload_data.h"

@@ -66,7 +66,7 @@ void RenderViewFakeResourcesTest::SetUp() {

webkit_glue::SetJavaScriptFlags("--expose-gc");

mock_process_.reset(new MockRenderProcess);

- render_thread_ = new RenderThreadImpl(channel_id);

+ render_thread_ = new content::RenderThreadImplNoSandbox(channel_id);

// Tell the renderer to create a view, then wait until it's ready.

// We can't call View::Create() directly here or else we won't get

« content/test/render_test_utils.h ('K') | « content/test/render_test_utils.cc ('k') | content/test/render_view_test.h » ('j') | no next file with comments »