Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2738)

Unified Diff: chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc

Issue 10449094: Fix client-side phishing detection test flakiness and ChromeOS failure. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Generalize the fix and apply it to webrtc_audio_device_test Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc
diff --git a/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc b/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc
index 47cf1f4c181c552c97b3989a57f5ba20037fa93b..aee8a388494efb471916fd76119f0c845f62a715 100644
--- a/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc
+++ b/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc
@@ -91,7 +91,7 @@ class PhishingDOMFeatureExtractorTest : public RenderViewFakeResourcesTest {
base::WeakPtrFactory<PhishingDOMFeatureExtractorTest> weak_factory_;
};
-TEST_F(PhishingDOMFeatureExtractorTest, DISABLED_FormFeatures) {
+TEST_F(PhishingDOMFeatureExtractorTest, FormFeatures) {
// This test doesn't exercise the extraction timing.
EXPECT_CALL(clock_, Now()).WillRepeatedly(Return(base::TimeTicks::Now()));
responses_["http://host.com/"] =
@@ -149,7 +149,7 @@ TEST_F(PhishingDOMFeatureExtractorTest, DISABLED_FormFeatures) {
EXPECT_THAT(features.features(), ContainerEq(expected_features.features()));
}
-TEST_F(PhishingDOMFeatureExtractorTest, DISABLED_LinkFeatures) {
+TEST_F(PhishingDOMFeatureExtractorTest, LinkFeatures) {
// This test doesn't exercise the extraction timing.
EXPECT_CALL(clock_, Now()).WillRepeatedly(Return(base::TimeTicks::Now()));
responses_["http://www.host.com/"] =
@@ -191,7 +191,7 @@ TEST_F(PhishingDOMFeatureExtractorTest, DISABLED_LinkFeatures) {
EXPECT_THAT(features.features(), ContainerEq(expected_features.features()));
}
-TEST_F(PhishingDOMFeatureExtractorTest, DISABLED_ScriptAndImageFeatures) {
+TEST_F(PhishingDOMFeatureExtractorTest, ScriptAndImageFeatures) {
// This test doesn't exercise the extraction timing.
EXPECT_CALL(clock_, Now()).WillRepeatedly(Return(base::TimeTicks::Now()));
responses_["http://host.com/"] =
@@ -222,7 +222,7 @@ TEST_F(PhishingDOMFeatureExtractorTest, DISABLED_ScriptAndImageFeatures) {
EXPECT_THAT(features.features(), ContainerEq(expected_features.features()));
}
-TEST_F(PhishingDOMFeatureExtractorTest, DISABLED_SubFrames) {
+TEST_F(PhishingDOMFeatureExtractorTest, SubFrames) {
// This test doesn't exercise the extraction timing.
EXPECT_CALL(clock_, Now()).WillRepeatedly(Return(base::TimeTicks::Now()));
@@ -357,7 +357,7 @@ TEST_F(PhishingDOMFeatureExtractorTest, Continuation) {
EXPECT_FALSE(ExtractFeatures(&features));
}
-TEST_F(PhishingDOMFeatureExtractorTest, DISABLED_SubframeRemoval) {
+TEST_F(PhishingDOMFeatureExtractorTest, SubframeRemoval) {
// In this test, we'll advance the feature extractor so that it is positioned
// inside an iframe, and have it pause due to exceeding the chunk time limit.
// Then, prior to continuation, the iframe is removed from the document.

Powered by Google App Engine
This is Rietveld 408576698