Fix client-side phishing detection test flakiness and ChromeOS failure.

content/test/render_test_utils.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+//
+// This file contains implementations of WebKitPlatformSupport and
+// RenderThreadImpl which can be used for tests, where sandbox support is
+// not available.
+
+#ifndef CONTENT_TEST_RENDER_TEST_UTILS_H_
+#define CONTENT_TEST_RENDER_TEST_UTILS_H_
+#pragma once
+
+#include "base/compiler_specific.h"
+#include "content/renderer/render_thread_impl.h"
+#include "content/renderer/renderer_webkitplatformsupport_impl.h"

[jam, 2012/06/01 22:11:24]

we don't allow headers in content/test to "leak through" internal headers of
content. i.e. tests in src/chrome shouldn't need to include internal content
files, just like they shouldn't include webcore files

+
+namespace content {
+
+class RendererWebKitPlatformSupportImplNoSandbox :
+      public RendererWebKitPlatformSupportImpl {
+ public:
+  virtual WebKit::WebSandboxSupport* sandboxSupport() OVERRIDE;
+};

[jochen (gone - plz use gerrit), 2012/06/01 12:11:38]

DISALLOW_COPY_AND_ASSING, here and below?

+
+class RenderThreadImplNoSandbox : public RenderThreadImpl {
+ public:
+  explicit RenderThreadImplNoSandbox(const std::string& channel_name);
+  virtual ~RenderThreadImplNoSandbox();
+
+ protected:
+  virtual RendererWebKitPlatformSupportImpl*
+      CreateWebKitPlatformSupport() OVERRIDE;
+};
+
+}  // namespace content
+
+#endif  // CONTENT_TEST_RENDER_TEST_UTILS_H_