Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2719)

Unified Diff: net/spdy/spdy_framer_test.cc

Issue 10448083: Fix out of order SYN_STEAM frames. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix willchan's comments Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_framer_test.cc
diff --git a/net/spdy/spdy_framer_test.cc b/net/spdy/spdy_framer_test.cc
index fd80da465c7b7e8bf4a5eb094a9856b0c6d673c9..9e20724d0fd0c8fe1410b00abe93e04efb7a5373 100644
--- a/net/spdy/spdy_framer_test.cc
+++ b/net/spdy/spdy_framer_test.cc
@@ -39,6 +39,9 @@ class MockVisitor : public SpdyFramerVisitorInterface {
const char* data,
size_t len));
MOCK_METHOD3(OnSetting, void(SpdySettingsIds id, uint8 flags, uint32 value));
+ MOCK_METHOD2(OnControlFrameCompressed,
+ void(const SpdyControlFrame& uncompressed_frame,
+ const SpdyControlFrame& compressed_frame));
};
class SpdyFramerTestUtil {
@@ -132,6 +135,10 @@ class SpdyFramerTestUtil {
virtual void OnSetting(SpdySettingsIds id, uint8 flags, uint32 value) {
LOG(FATAL);
}
+ virtual void OnControlFrameCompressed(
+ const SpdyControlFrame& uncompressed_frame,
+ const SpdyControlFrame& compressed_frame) {
+ }
char* ReleaseBuffer() {
CHECK(finished_);
@@ -322,6 +329,11 @@ class TestSpdyVisitor : public SpdyFramerVisitorInterface {
setting_count_++;
}
+ virtual void OnControlFrameCompressed(
+ const SpdyControlFrame& uncompressed_frame,
+ const SpdyControlFrame& compressed_frame) {
+ }
+
bool OnControlFrameHeaderData(SpdyStreamId stream_id,
const char* header_data,
size_t len) {
@@ -3020,6 +3032,7 @@ TEST_P(SpdyFramerTest, EmptySynStream) {
SpdyFramer framer(spdy_version_);
framer.set_visitor(&visitor);
+ EXPECT_CALL(visitor, OnControlFrameCompressed(_, _));
scoped_ptr<SpdySynStreamControlFrame>
frame(framer.CreateSynStream(1, 0, 1, 0, CONTROL_FLAG_NONE, true,
&headers));

Powered by Google App Engine
This is Rietveld 408576698