Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Side by Side Diff: net/spdy/buffered_spdy_framer_spdy3_unittest.cc

Issue 10448083: Fix out of order SYN_STEAM frames. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix willchan's comments Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/spdy/buffered_spdy_framer.h" 5 #include "net/spdy/buffered_spdy_framer.h"
6 6
7 #include "net/spdy/spdy_test_util_spdy3.h" 7 #include "net/spdy/spdy_test_util_spdy3.h"
8 #include "testing/platform_test.h" 8 #include "testing/platform_test.h"
9 9
10 using namespace net::test_spdy3; 10 using namespace net::test_spdy3;
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 void OnStreamFrameData(SpdyStreamId stream_id, 64 void OnStreamFrameData(SpdyStreamId stream_id,
65 const char* data, 65 const char* data,
66 size_t len) { 66 size_t len) {
67 LOG(FATAL) << "Unexpected OnStreamFrameData call."; 67 LOG(FATAL) << "Unexpected OnStreamFrameData call.";
68 } 68 }
69 69
70 void OnSetting(SpdySettingsIds id, uint8 flags, uint32 value) { 70 void OnSetting(SpdySettingsIds id, uint8 flags, uint32 value) {
71 setting_count_++; 71 setting_count_++;
72 } 72 }
73 73
74 void OnControlFrameCompressed(
75 const SpdyControlFrame& uncompressed_frame,
76 const SpdyControlFrame& compressed_frame) {
77 }
78
74 bool OnCredentialFrameData(const char*, size_t) { 79 bool OnCredentialFrameData(const char*, size_t) {
75 LOG(FATAL) << "Unexpected OnCredentialFrameData call."; 80 LOG(FATAL) << "Unexpected OnCredentialFrameData call.";
76 return false; 81 return false;
77 } 82 }
78 83
79 void OnDataFrameHeader(const SpdyDataFrame* frame) { 84 void OnDataFrameHeader(const SpdyDataFrame* frame) {
80 LOG(FATAL) << "Unexpected OnDataFrameHeader call."; 85 LOG(FATAL) << "Unexpected OnDataFrameHeader call.";
81 } 86 }
82 87
83 void OnControl(const SpdyControlFrame* frame) { 88 void OnControl(const SpdyControlFrame* frame) {
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
257 visitor.SimulateInFramer( 262 visitor.SimulateInFramer(
258 reinterpret_cast<unsigned char*>(control_frame.get()->data()), 263 reinterpret_cast<unsigned char*>(control_frame.get()->data()),
259 control_frame.get()->length() + SpdyControlFrame::kHeaderSize); 264 control_frame.get()->length() + SpdyControlFrame::kHeaderSize);
260 EXPECT_EQ(0, visitor.error_count_); 265 EXPECT_EQ(0, visitor.error_count_);
261 EXPECT_EQ(0, visitor.syn_frame_count_); 266 EXPECT_EQ(0, visitor.syn_frame_count_);
262 EXPECT_EQ(0, visitor.syn_reply_frame_count_); 267 EXPECT_EQ(0, visitor.syn_reply_frame_count_);
263 EXPECT_EQ(1, visitor.headers_frame_count_); 268 EXPECT_EQ(1, visitor.headers_frame_count_);
264 EXPECT_TRUE(CompareHeaderBlocks(&headers, &visitor.headers_)); 269 EXPECT_TRUE(CompareHeaderBlocks(&headers, &visitor.headers_));
265 } 270 }
266 } // namespace net 271 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698