ui/web_dialogs/web_dialogs.gyp - Issue 10448066: Move the web dialogs code to src/ui/web_dialogs from src/chrome

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/web_dialogs/web_dialogs.gyp

Issue 10448066: Move the web dialogs code to src/ui/web_dialogs from src/chrome (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
	tfarina 2012/05/30 19:16:19 btw, very nice and clean gyp file :) Yay. btw, very nice and clean gyp file :) Yay. mazda 2012/05/30 20:14:12 Thanks. :) Show quoted text On 2012/05/30 19:16:19, tfarina wrote: > btw, very nice and clean gyp file :) Yay. Thanks. :)
	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 {

	6 'variables': {

	7 'chromium_code': 1,

	8 },

	9 'targets': [

	10 {

	11 'target_name': 'web_dialogs',

	12 'type': '<(component)',

	13 'dependencies': [

	14 '../../base/base.gyp:base',

	15 '../../skia/skia.gyp:skia',

	16 ],

	17 'defines': [

	18 'WEB_DIALOGS_IMPLEMENTATION',

	19 ],

	20 'sources': [

	21 # All .cc, .h under web_dialogs, except unittests
	tfarina 2012/05/30 19:16:19 nit: end with period. Yeah, I know we have all the nit: end with period. Yeah, I know we have all the other comments without periods unfortunately. mazda 2012/05/30 20:14:12 Done. Show quoted text On 2012/05/30 19:16:19, tfarina wrote: > nit: end with period. Yeah, I know we have all the other comments without > periods unfortunately. Done.
	22 'constrained_web_dialog_ui.cc',

	23 'constrained_web_dialog_ui.h',

	24 'web_dialog_delegate.h',

	25 'web_dialog_observer.h',

	26 'web_dialog_ui.cc',

	27 'web_dialog_ui.h',

	28 'web_dialogs_export.h',

	29 ],

	30 },

	31 ],

	32 }

OLD	NEW