Unwire the clear on exit preference from the storage systems.

content/browser/appcache/chrome_appcache_service_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/file_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/message_loop.h"
 #include "base/scoped_temp_dir.h"
 #include "content/browser/browser_thread_impl.h"
@@ skipping 108 matching lines @@
   FilePath appcache_path = temp_dir_.path().Append(kTestingAppCacheDirname);
 
   // Create a ChromeAppCacheService and insert data into it
   scoped_refptr<ChromeAppCacheService> appcache_service =
       CreateAppCacheService(appcache_path, true);
   ASSERT_TRUE(file_util::PathExists(appcache_path));
   ASSERT_TRUE(file_util::PathExists(appcache_path.AppendASCII("Index")));
   InsertDataIntoAppCache(appcache_service);
 
   // Test: delete the ChromeAppCacheService
-  appcache_service->set_clear_local_state_on_exit(false);
   appcache_service = NULL;
   message_loop_.RunAllPending();
 
   // Recreate the appcache (for reading the data back)
   appcache_service = CreateAppCacheService(appcache_path, false);
 
   // The directory is still there
   ASSERT_TRUE(file_util::PathExists(appcache_path));
 
   // The appcache data is also there, except the session-only origin.
   AppCacheTestHelper appcache_helper;
   std::set<GURL> origins;
   appcache_helper.GetOriginsWithCaches(appcache_service, &origins);
   EXPECT_EQ(2UL, origins.size());
   EXPECT_TRUE(origins.find(kProtectedManifestURL.GetOrigin()) != origins.end());
   EXPECT_TRUE(origins.find(kNormalManifestURL.GetOrigin()) != origins.end());
   EXPECT_TRUE(origins.find(kSessionOnlyManifestURL.GetOrigin()) ==
               origins.end());
 
   // Delete and let cleanup tasks run prior to returning.
   appcache_service = NULL;
   message_loop_.RunAllPending();
 }
 
-TEST_F(ChromeAppCacheServiceTest, RemoveOnDestruction) {
-  ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
-  FilePath appcache_path = temp_dir_.path().Append(kTestingAppCacheDirname);
-
-  // Create a ChromeAppCacheService and insert data into it
-  scoped_refptr<ChromeAppCacheService> appcache_service =
-      CreateAppCacheService(appcache_path, true);
-  ASSERT_TRUE(file_util::PathExists(appcache_path));
-  ASSERT_TRUE(file_util::PathExists(appcache_path.AppendASCII("Index")));
-  InsertDataIntoAppCache(appcache_service);
-
-  // Test: delete the ChromeAppCacheService
-  appcache_service->set_clear_local_state_on_exit(true);
-  appcache_service = NULL;
-  message_loop_.RunAllPending();
-
-  // Recreate the appcache (for reading the data back)
-  appcache_service = CreateAppCacheService(appcache_path, false);
-
-  // The directory is still there
-  ASSERT_TRUE(file_util::PathExists(appcache_path));
-
-  // The appcache data for the protected origin is there, and the data for the
-  // unprotected origin was deleted.
-  AppCacheTestHelper appcache_helper;
-  std::set<GURL> origins;
-  appcache_helper.GetOriginsWithCaches(appcache_service, &origins);
-  EXPECT_EQ(1UL, origins.size());
-  EXPECT_TRUE(origins.find(kProtectedManifestURL.GetOrigin()) != origins.end());
-  EXPECT_TRUE(origins.find(kNormalManifestURL.GetOrigin()) == origins.end());
-  EXPECT_TRUE(origins.find(kSessionOnlyManifestURL.GetOrigin()) ==
-              origins.end());
-
-  // Delete and let cleanup tasks run prior to returning.
-  appcache_service = NULL;
-  message_loop_.RunAllPending();
-}
-
 TEST_F(ChromeAppCacheServiceTest, SaveSessionState) {
   ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
   FilePath appcache_path = temp_dir_.path().Append(kTestingAppCacheDirname);
 
   // Create a ChromeAppCacheService and insert data into it
   scoped_refptr<ChromeAppCacheService> appcache_service =
       CreateAppCacheService(appcache_path, true);
   ASSERT_TRUE(file_util::PathExists(appcache_path));
   ASSERT_TRUE(file_util::PathExists(appcache_path.AppendASCII("Index")));
   InsertDataIntoAppCache(appcache_service);
 
-  appcache_service->set_clear_local_state_on_exit(true);
   // Save session state. This should bypass the destruction-time deletion.
-  appcache_service->set_save_session_state(true);
+  appcache_service->set_force_keep_session_state();
 
   // Test: delete the ChromeAppCacheService
   appcache_service = NULL;
   message_loop_.RunAllPending();
 
   // Recreate the appcache (for reading the data back)
   appcache_service = CreateAppCacheService(appcache_path, false);
 
   // The directory is still there
   ASSERT_TRUE(file_util::PathExists(appcache_path));
 
   // No appcache data was deleted.
   AppCacheTestHelper appcache_helper;
   std::set<GURL> origins;
   appcache_helper.GetOriginsWithCaches(appcache_service, &origins);
   EXPECT_EQ(3UL, origins.size());
   EXPECT_TRUE(origins.find(kProtectedManifestURL.GetOrigin()) != origins.end());
   EXPECT_TRUE(origins.find(kNormalManifestURL.GetOrigin()) != origins.end());
   EXPECT_TRUE(origins.find(kSessionOnlyManifestURL.GetOrigin()) !=
               origins.end());
 
   // Delete and let cleanup tasks run prior to returning.
   appcache_service = NULL;
   message_loop_.RunAllPending();
 }
 
 }  // namespace appcache