Issue 10447110: WebKit will start using NaN to indicate null/invalid time

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10447110: WebKit will start using NaN to indicate null/invalid time (Closed)

Created:
8 years, 6 months ago by kinuko

Modified:
8 years, 6 months ago

Reviewers:
brettw, willchan no longer on Chromium

CC:
chromium-reviews, erikwright (departed), darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

WebKit will start using NaN for null/invalid modificationTime Per discussion on webkit bugzilla WebKit will start using NaN for null/invalidmodificationTime (instead of 0.0, our conventional null time value) https://bugs.webkit.org/show_bug.cgi?id=87709#c10 https://bugs.webkit.org/show_bug.cgi?id=87826 BUG=none TEST=existing tests should pass Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140710

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -1 line)			Patch
	M	base/time.cc	View		3 chunks	+13 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

kinuko

I can instead only changing glue code between WebKit/chromium boundary but it sounds very error ...

8 years, 6 months ago (2012-06-05 12:11:05 UTC) #1

lgtm