Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: pylib/gyp/generator/ninja_test.py

Issue 10447063: Fix make and ninja backends to sensibly handle duplicate target names in different directories (Closed) Base URL: http://git.chromium.org/external/gyp.git@master
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pylib/gyp/generator/ninja_test.py
===================================================================
--- pylib/gyp/generator/ninja_test.py (revision 1413)
+++ pylib/gyp/generator/ninja_test.py (working copy)
@@ -16,7 +16,7 @@
class TestPrefixesAndSuffixes(unittest.TestCase):
if sys.platform in ('win32', 'cygwin'):
def test_BinaryNamesWindows(self):
- writer = ninja.NinjaWriter('wee', '.', '.', 'ninja.build', 'win')
+ writer = ninja.NinjaWriter('foo', 'wee', '.', '.', 'ninja.build', 'win')
spec = { 'target_name': 'wee' }
self.assertTrue(writer.ComputeOutputFileName(spec, 'executable').
endswith('.exe'))
@@ -27,7 +27,7 @@
if sys.platform == 'linux2':
def test_BinaryNamesLinux(self):
- writer = ninja.NinjaWriter('wee', '.', '.', 'ninja.build', 'linux')
+ writer = ninja.NinjaWriter('foo', 'wee', '.', '.', 'ninja.build', 'linux')
spec = { 'target_name': 'wee' }
self.assertTrue('.' not in writer.ComputeOutputFileName(spec,
'executable'))

Powered by Google App Engine
This is Rietveld 408576698