Introduce library ids and info in the wire protocol

runtime/bin/dbg_connection.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/dbg_connection.h"
 #include "bin/dartutils.h"
 #include "bin/socket.h"
 #include "bin/thread.h"
 #include "bin/utils.h"
 
@@ skipping 195 matching lines @@
 
 
 void DebuggerConnectionHandler::SendError(int msg_id,
                                           const char* err_msg) {
   dart::TextBuffer msg(64);
   msg.Printf("{\"id\": %d, \"error\": \"Error: %s\"}", msg_id, err_msg);
   SendMsg(&msg);
 }
 
 
+static const char* GetStringChars(Dart_Handle str) {
+  ASSERT(Dart_IsString(str));
+  const char* chars;
+  Dart_Handle res = Dart_StringToCString(str, &chars);
+  ASSERT(!Dart_IsError(res));
+  return chars;
+}
+
+
+static int GetIntValue(Dart_Handle int_handle) {
+  int64_t int64_val = -1;
+  ASSERT(Dart_IsInteger(int_handle));
+  Dart_Handle res = Dart_IntegerToInt64(int_handle, &int64_val);
+  ASSERT(!Dart_IsError(res));
+  // TODO(hausner): Range check.
+  return int64_val;
+}
+
+
 void DebuggerConnectionHandler::HandleResumeCmd(const char* json_msg) {
   int msg_id = msgbuf_->MessageId();
   dart::TextBuffer msg(64);
   msg.Printf("{ \"id\": %d }", msg_id);
   SendMsg(&msg);
   request_resume_ = true;
 }
 
 
 void DebuggerConnectionHandler::HandleStepIntoCmd(const char* json_msg) {
@@ skipping 13 matching lines @@
 void DebuggerConnectionHandler::HandleStepOverCmd(const char* json_msg) {
   Dart_Handle res = Dart_SetStepOver();
   ASSERT_NOT_ERROR(res);
   HandleResumeCmd(json_msg);
 }
 
 
 void DebuggerConnectionHandler::HandleGetScriptURLsCmd(const char* json_msg) {
   int msg_id = msgbuf_->MessageId();
   dart::TextBuffer msg(64);
-  const char* params = msgbuf_->Params();
-  ASSERT(params != NULL);
-  dart::JSONReader pr(params);
-  pr.Seek("library");
-  ASSERT(pr.Type() == dart::JSONReader::kString);
-  char lib_url_chars[128];
-  pr.GetValueChars(lib_url_chars, sizeof(lib_url_chars));
-  Dart_Handle lib_url = Dart_NewString(lib_url_chars);
+  intptr_t lib_id = msgbuf_->GetIntParam("libraryId");
+  Dart_Handle lib_url = Dart_GetLibraryURL(lib_id);
   ASSERT_NOT_ERROR(lib_url);
   Dart_Handle urls = Dart_GetScriptURLs(lib_url);
   if (Dart_IsError(urls)) {
     SendError(msg_id, Dart_GetError(urls));
     return;
   }
   ASSERT(Dart_IsList(urls));
   intptr_t num_urls = 0;
   Dart_ListLength(urls, &num_urls);
   msg.Printf("{ \"id\": %d, ", msg_id);
   msg.Printf("\"result\": { \"urls\": [");
   for (int i = 0; i < num_urls; i++) {
     Dart_Handle script_url = Dart_ListGetAt(urls, i);
     ASSERT(Dart_IsString(script_url));
     char const* chars;
     Dart_StringToCString(lib_url, &chars);
     msg.Printf("%s\"%s\"", (i == 0) ? "" : ", ", chars);
   }
   msg.Printf("] }}");
   SendMsg(&msg);
 }
 
 
-void DebuggerConnectionHandler::HandleGetLibraryURLsCmd(const char* json_msg) {
+void DebuggerConnectionHandler::HandleGetLibrariesCmd(const char* json_msg) {
   int msg_id = msgbuf_->MessageId();
   dart::TextBuffer msg(64);
-  msg.Printf("{ \"id\": %d, \"result\": { \"urls\": [", msg_id);
-  Dart_Handle urls = Dart_GetLibraryURLs();
-  ASSERT_NOT_ERROR(urls);
+  msg.Printf("{ \"id\": %d, \"result\": { \"libraries\": [", msg_id);
+  Dart_Handle lib_ids = Dart_GetLibraryIds();
+  ASSERT_NOT_ERROR(lib_ids);
   intptr_t num_libs;
-  Dart_ListLength(urls, &num_libs);
+  Dart_ListLength(lib_ids, &num_libs);

[siva, 2012/05/29 18:07:53]

ASSERT return value is not an error?

[hausner, 2012/05/29 19:48:18]

Done.

   for (int i = 0; i < num_libs; i++) {
-    Dart_Handle lib_url = Dart_ListGetAt(urls, i);
+    Dart_Handle lib_id_handle = Dart_ListGetAt(lib_ids, i);
+    ASSERT(Dart_IsInteger(lib_id_handle));
+    int lib_id = GetIntValue(lib_id_handle);
+    Dart_Handle lib_url = Dart_GetLibraryURL(lib_id);
+    ASSERT_NOT_ERROR(lib_url);
+    ASSERT(!Dart_IsNull(lib_url));
     ASSERT(Dart_IsString(lib_url));
-    char const* chars;
+    char const* chars = NULL;
     Dart_StringToCString(lib_url, &chars);
-    msg.Printf("%s\"%s\"", (i == 0) ? "" : ", ", chars);
+    msg.Printf("%s{\"id\":%d,\"url\":\"%s\"}",
+               (i == 0) ? "" : ", ", lib_id, chars);

[siva, 2012/05/29 18:07:53]

maybe use GetStringChars(lib_url) here instead of 'chars' and remove the 3 lines
above msg.Printf...

[hausner, 2012/05/29 19:48:18]

Yes. 
On 2012/05/29 18:07:53, asiva wrote:

   }
-  msg.Printf("] }}");
+  msg.Printf("]}}");
   SendMsg(&msg);
 }
 
 
-static const char* GetStringChars(Dart_Handle str) {
-  ASSERT(Dart_IsString(str));
-  const char* chars;
-  Dart_Handle res = Dart_StringToCString(str, &chars);
-  ASSERT(!Dart_IsError(res));
-  return chars;
-}
-
-
 static void FormatField(dart::TextBuffer* buf,
                         Dart_Handle object_name,
                         Dart_Handle object) {
   ASSERT(Dart_IsString(object_name));
   buf->Printf("{\"name\":\"%s\",", GetStringChars(object_name));
   intptr_t obj_id = Dart_CacheObject(object);
   ASSERT(obj_id >= 0);
   buf->Printf("\"value\":{\"objectId\":%d,", obj_id);
   const char* kind = "object";
   if (Dart_IsInteger(object)) {
@@ skipping 26 matching lines @@
       buf->Printf(",");
     }
     FormatField(buf, name_handle, value_handle);
   }
   buf->Printf("]");
 }
 
 
 static const char* FormatClassProps(dart::TextBuffer* buf,
                                     intptr_t cls_id) {
-  Dart_Handle name, library, static_fields;
-  intptr_t super_id;
+  Dart_Handle name, static_fields;
+  intptr_t super_id = -1;
+  intptr_t library_id = -1;
   Dart_Handle res =
-      Dart_GetClassInfo(cls_id, &name, &library, &super_id, &static_fields);
+      Dart_GetClassInfo(cls_id, &name, &library_id, &super_id, &static_fields);
   RETURN_IF_ERROR(res);
   RETURN_IF_ERROR(name);
   buf->Printf("{\"name\":\"%s\",", GetStringChars(name));
   if (super_id > 0) {
     buf->Printf("\"superclassId\":%d,", super_id);
   }
-  RETURN_IF_ERROR(library);
-  ASSERT(!Dart_IsNull(library));
-  // TODO(hausner): get proper library id.
-  intptr_t libId = 0;
-  buf->Printf("\"libraryId\":%d,", libId);
+  buf->Printf("\"libraryId\":%d,", library_id);
   RETURN_IF_ERROR(static_fields);
   buf->Printf("\"fields\":");
   FormatFieldList(buf, static_fields);
   buf->Printf("}");
   return NULL;
 }
 
 
+static const char* FormatLibraryProps(dart::TextBuffer* buf,
+                                    intptr_t lib_id) {

[siva, 2012/05/29 18:07:53]

indentation?

[hausner, 2012/05/29 19:48:18]

Done.

+  Dart_Handle url = Dart_GetLibraryURL(lib_id);
+  RETURN_IF_ERROR(url);
+  buf->Printf("{\"url\":\"%s\",", GetStringChars(url));
+
+  // Imports and prefixes.
+  Dart_Handle import_list = Dart_GetLibraryImports(lib_id);
+  RETURN_IF_ERROR(import_list);
+  ASSERT(Dart_IsList(import_list));
+  intptr_t list_length = 0;
+  Dart_Handle res = Dart_ListLength(import_list, &list_length);
+  RETURN_IF_ERROR(res);
+  buf->Printf("\"imports\":[");
+  for (int i = 0; i + 1 < list_length; i += 2) {
+    Dart_Handle lib_id = Dart_ListGetAt(import_list, i + 1);
+    ASSERT_NOT_ERROR(lib_id);
+    buf->Printf("%s{\"libraryId\":%d,",
+                (i > 0) ? ",": "",
+                GetIntValue(lib_id));
+
+    Dart_Handle name = Dart_ListGetAt(import_list, i);
+    ASSERT_NOT_ERROR(name);
+    buf->Printf("\"prefix\":\"%s\"}",
+                Dart_IsNull(name) ? "" : GetStringChars(name));
+  }
+  buf->Printf("],");
+
+  // Global variables in the library.
+  Dart_Handle global_vars = Dart_GetLibraryFields(lib_id);
+  RETURN_IF_ERROR(global_vars);
+  buf->Printf("\"globals\":");
+  FormatFieldList(buf, global_vars);
+  buf->Printf("}");
+  return NULL;
+}
+
+
 static const char* FormatObjProps(dart::TextBuffer* buf,
                                   Dart_Handle object) {
   intptr_t class_id;
+  if (Dart_IsNull(object)) {
+    buf->Printf("{\"classId\":-1,\"fields\":[]}");
+    return NULL;
+  }
   Dart_Handle res = Dart_GetObjClassId(object, &class_id);
   RETURN_IF_ERROR(res);
   buf->Printf("{\"classId\": %d, \"fields\":", class_id);
   Dart_Handle fields = Dart_GetInstanceFields(object);
   RETURN_IF_ERROR(fields);
   FormatFieldList(buf, fields);
   buf->Printf("}");
   return NULL;
 }
 
@@ skipping 70 matching lines @@
   uint64_t bp_id_value;
   Dart_Handle res = Dart_IntegerToUint64(bp_id, &bp_id_value);
   ASSERT_NOT_ERROR(res);
   dart::TextBuffer msg(64);
   msg.Printf("{ \"id\": %d, \"result\": { \"breakpointId\": %d }}",
              msg_id, bp_id_value);
   SendMsg(&msg);
 }
 
 
+void DebuggerConnectionHandler::HandleRemBpCmd(const char* json_msg) {
+  int msg_id = msgbuf_->MessageId();
+  int bpt_id = msgbuf_->GetIntParam("breakpointId");
+  Dart_Handle res = Dart_RemoveBreakpoint(bpt_id);
+  ASSERT_NOT_ERROR(res);
+  dart::TextBuffer msg(32);
+  msg.Printf("{ \"id\": %d }", msg_id);

[siva, 2012/05/29 18:07:53]

Shouldn't the reply have an Error reply so that the caller knows if the
breakpoint was deleted.
e.g: an invalid breakpoint id is passed in due to a typo or bug, the tool will
assume the breakpoint was deleted.

[hausner, 2012/05/29 19:48:18]

Done.

+  SendMsg(&msg);
+}
+
+
 void DebuggerConnectionHandler::HandleGetObjPropsCmd(const char* json_msg) {
   int msg_id = msgbuf_->MessageId();
   intptr_t obj_id = msgbuf_->GetIntParam("objectId");
   Dart_Handle obj = Dart_GetCachedObject(obj_id);
   if (Dart_IsError(obj)) {
     SendError(msg_id, Dart_GetError(obj));
     return;
   }
   dart::TextBuffer msg(64);
   msg.Printf("{\"id\":%d, \"result\":", msg_id);
@@ skipping 15 matching lines @@
   const char* err = FormatClassProps(&msg, cls_id);
   if (err != NULL) {
     SendError(msg_id, err);
     return;
   }
   msg.Printf("}");
   SendMsg(&msg);
 }
 
 
+void DebuggerConnectionHandler::HandleGetLibPropsCmd(const char* json_msg) {
+  int msg_id = msgbuf_->MessageId();
+  intptr_t cls_id = msgbuf_->GetIntParam("libraryId");
+  dart::TextBuffer msg(64);
+  msg.Printf("{\"id\":%d, \"result\":", msg_id);
+  const char* err = FormatLibraryProps(&msg, cls_id);
+  if (err != NULL) {
+    SendError(msg_id, err);
+    return;
+  }
+  msg.Printf("}");
+  SendMsg(&msg);
+}
+
+
 void DebuggerConnectionHandler::HandleUnknownMsg(const char* json_msg) {
   int msg_id = msgbuf_->MessageId();
   ASSERT(msg_id >= 0);
   SendError(msg_id, "unknown debugger command");
 }
 
 
 void DebuggerConnectionHandler::HandleMessages() {
   static JSONDebuggerCommand debugger_commands[] = {
     { "resume", HandleResumeCmd },
-    { "getLibraryURLs", HandleGetLibraryURLsCmd },
+    { "getLibraries", HandleGetLibrariesCmd },
     { "getClassProperties", HandleGetClassPropsCmd },
+    { "getLibraryProperties", HandleGetLibPropsCmd },
     { "getObjectProperties", HandleGetObjPropsCmd },
     { "getScriptURLs", HandleGetScriptURLsCmd },
     { "getStackTrace", HandleGetStackTraceCmd },
     { "setBreakpoint", HandleSetBpCmd },
+    { "removeBreakpoint", HandleRemBpCmd },
     { "stepInto", HandleStepIntoCmd },
     { "stepOut", HandleStepOutCmd },
     { "stepOver", HandleStepOverCmd },
     { NULL, NULL }
   };
 
   for (;;) {
     SendQueuedMsgs();
     while (!msgbuf_->IsValidMessage() && msgbuf_->Alive()) {
       msgbuf_->ReadData();
@@ skipping 117 matching lines @@
   handler_started_ = true;
   DebuggerConnectionImpl::StartHandler(port_number);
   Dart_SetBreakpointHandler(BreakpointHandler);
   Dart_SetBreakpointResolvedHandler(BptResolvedHandler);
 }
 
 
 DebuggerConnectionHandler::~DebuggerConnectionHandler() {
   CloseDbgConnection();
 }