Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1119)

Unified Diff: media/base/test_data_util.h

Issue 10447035: Introducing DecoderBuffer and general Buffer cleanup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fixes. Rebase. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/test_data_util.h
diff --git a/media/base/test_data_util.h b/media/base/test_data_util.h
index a132875bf8d7edc41bf77e546bfc31d01491acbc..81efa802165690bac3f95eff16b87285a91c3482 100644
--- a/media/base/test_data_util.h
+++ b/media/base/test_data_util.h
@@ -13,36 +13,18 @@
namespace media {
-class Buffer;
-class DataBuffer;
+class DecoderBuffer;
// Returns a URL path for a file in the media/test/data directory.
std::string GetTestDataURL(const std::string& name);
// Reads a test file from media/test/data directory and stores it in
-// a scoped_array.
+// a DecoderBuffer. Use DecoderBuffer vs DataBuffer to ensure no matter
+// what a test does, it's safe to use FFmpeg methods.
//
// |name| - The name of the file.
// |buffer| - The contents of the file.
-// |size| - The size of the buffer.
-void ReadTestDataFile(const std::string& name,
- scoped_array<uint8>* buffer,
- int* size);
-
-// Reads a test file from media/test/data directory and stores it in
-// a DataBuffer.
-//
-// |name| - The name of the file.
-// |buffer| - The contents of the file.
-void ReadTestDataFile(const std::string& name,
- scoped_refptr<DataBuffer>* buffer);
-
-// Reads a test file from media/test/data directory and stores it in
-// a Buffer.
-//
-// |name| - The name of the file.
-// |buffer| - The contents of the file.
-void ReadTestDataFile(const std::string& name, scoped_refptr<Buffer>* buffer);
+scoped_refptr<DecoderBuffer> ReadTestDataFile(const std::string& name);
} // namespace media

Powered by Google App Engine
This is Rietveld 408576698