Issue 10447034: Fix for issue 2981

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10447034: Fix for issue 2981 (Closed)

Created:
8 years, 7 months ago by Brian Wilkerson

Modified:
8 years, 7 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix for issue 2981 Committed: https://code.google.com/p/dart/source/detail?r=8007

Patch Set 1 #

Total comments: 2

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/DartElementLocator.java	View		1 chunk	+7 lines, -3 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheglov

LGTM http://codereview.chromium.org/10447034/diff/1/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/DartElementLocator.java File editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/DartElementLocator.java (right): http://codereview.chromium.org/10447034/diff/1/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/DartElementLocator.java#newcode427 editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/DartElementLocator.java:427: SourceRange uriRange = imprt.getUriRange(); If this variable is ...

8 years, 7 months ago (2012-05-25 17:26:36 UTC) #2

Brian Wilkerson

8 years, 7 months ago (2012-05-25 17:37:10 UTC) #3

http://codereview.chromium.org/10447034/diff/1/editor/tools/plugins/com.googl...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/DartElementLocator.java
(right):

http://codereview.chromium.org/10447034/diff/1/editor/tools/plugins/com.googl...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/DartElementLocator.java:427:
SourceRange uriRange = imprt.getUriRange();
Done.

Expand Messages | Collapse Messages