Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5677)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/nacl_host/nacl_process_host.cc

Issue 10447012: Add nacl-gdb-script switch. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/app/generated_resources.grd ('K') | « chrome/browser/about_flags.cc ('k') | chrome/browser/nacl_host/test/mock_nacl_gdb.cc » ('j') | chrome/browser/nacl_host/test/mock_nacl_gdb.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/nacl_host/nacl_process_host.cc
===================================================================
--- chrome/browser/nacl_host/nacl_process_host.cc (revision 138748)
+++ chrome/browser/nacl_host/nacl_process_host.cc (working copy)
@@ -312,6 +312,12 @@
cmd_line->AppendArgNative(FILE_PATH_LITERAL("nacl-manifest ") +
manifest_path.value());
}
+ const FilePath script = CommandLine::ForCurrentProcess()->GetSwitchValuePath(
Mark Seaborn 2012/05/24 17:25:58 Nit: 'const' seems unnecessary for a simple, non-r
halyavin 2012/05/25 09:37:45 Done.
+ switches::kNaClGdbScript);
+ if (!script.empty()) {
+ cmd_line->AppendArg("--command");
+ cmd_line->AppendArgNative(script.value());
+ }
cmd_line->AppendArg("--args");
const CommandLine::StringVector& argv = line->argv();
for (size_t i = 0; i < argv.size(); i++) {
« chrome/app/generated_resources.grd ('K') | « chrome/browser/about_flags.cc ('k') | chrome/browser/nacl_host/test/mock_nacl_gdb.cc » ('j') | chrome/browser/nacl_host/test/mock_nacl_gdb.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698