Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7284)

Unified Diff: chrome/installer/util/install_util.cc

Issue 10446111: Abstract suffixing logic away from GetApplicationName (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: 2012 Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/install_util.cc
diff --git a/chrome/installer/util/install_util.cc b/chrome/installer/util/install_util.cc
index 4b096efea481c58e706d55ba76082308b5d973b2..2b26f8a835e61c63f5023cb96cf4cdf2faa7155d 100644
--- a/chrome/installer/util/install_util.cc
+++ b/chrome/installer/util/install_util.cc
@@ -185,13 +185,12 @@ Version* InstallUtil::GetChromeVersion(BrowserDistribution* dist,
Version* ret = NULL;
if (result == ERROR_SUCCESS && !version_str.empty()) {
- VLOG(1) << "Existing " << dist->GetApplicationName()
- << " version found " << version_str;
+ VLOG(1) << "Existing " << dist->GetBaseAppName() << " version found "
+ << version_str;
ret = Version::GetVersionFromString(WideToASCII(version_str));
} else {
DCHECK_EQ(ERROR_FILE_NOT_FOUND, result);
- VLOG(1) << "No existing " << dist->GetApplicationName()
- << " install found.";
+ VLOG(1) << "No existing " << dist->GetBaseAppName() << " install found.";
}
return ret;
@@ -212,13 +211,12 @@ Version* InstallUtil::GetCriticalUpdateVersion(BrowserDistribution* dist,
Version* ret = NULL;
if (result == ERROR_SUCCESS && !version_str.empty()) {
- VLOG(1) << "Critical Update version for " << dist->GetApplicationName()
+ VLOG(1) << "Critical Update version for " << dist->GetBaseAppName()
<< " found " << version_str;
ret = Version::GetVersionFromString(WideToASCII(version_str));
} else {
DCHECK_EQ(ERROR_FILE_NOT_FOUND, result);
- VLOG(1) << "No existing " << dist->GetApplicationName()
- << " install found.";
+ VLOG(1) << "No existing " << dist->GetBaseAppName() << " install found.";
}
return ret;

Powered by Google App Engine
This is Rietveld 408576698