Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3765)

Unified Diff: chrome/installer/util/browser_distribution.h

Issue 10446111: Abstract suffixing logic away from GetApplicationName (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: 2012 Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/browser_distribution.h
diff --git a/chrome/installer/util/browser_distribution.h b/chrome/installer/util/browser_distribution.h
index 8944db98af386e3c52e97785b4eaa6865f772a39..391ac97857b207aeb5ae341cf14803114a37ad2c 100644
--- a/chrome/installer/util/browser_distribution.h
+++ b/chrome/installer/util/browser_distribution.h
@@ -67,9 +67,11 @@ class BrowserDistribution {
virtual string16 GetAppGuid();
- // Returns the name by which the program is registered with Default Programs.
- // This is not a localized string suitable for presenting to a user.
- virtual string16 GetApplicationName();
+ // Returns the unsuffixed application name of this program.
grt (UTC plus 2) 2012/06/08 19:54:21 I think the mention of "Default Programs" was usef
gab 2012/06/11 16:04:40 Done.
+ // IMPORTANT: This should only be called by the installer which needs to make
+ // decisions on the suffixing of the upcoming install (or by logging code that
+ // doesn't care about the suffixes), not by external callers at run-time.
+ virtual string16 GetBaseAppName();
// Returns the localized name of the program.
virtual string16 GetAppShortCutName();

Powered by Google App Engine
This is Rietveld 408576698