Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3041)

Unified Diff: chrome/installer/setup/uninstall.cc

Issue 10446111: Abstract suffixing logic away from GetApplicationName (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: 2012 Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/setup/uninstall.cc
diff --git a/chrome/installer/setup/uninstall.cc b/chrome/installer/setup/uninstall.cc
index d17bd47b2cb7682ec3523fb06ee09abe0b39968e..fb67159f3c4f2d1aa765b453fb7c5435a8723151 100644
--- a/chrome/installer/setup/uninstall.cc
+++ b/chrome/installer/setup/uninstall.cc
@@ -572,7 +572,7 @@ bool DeleteChromeRegistrationKeys(BrowserDistribution* dist, HKEY root,
// Delete Software\RegisteredApplications\Chromium
InstallUtil::DeleteRegistryValue(root, ShellUtil::kRegRegisteredApplications,
- dist->GetApplicationName() + browser_entry_suffix);
+ dist->GetBaseAppName() + browser_entry_suffix);
// Delete Software\Classes\Applications\chrome.exe
string16 app_key(ShellUtil::kRegClasses);
@@ -609,8 +609,7 @@ bool DeleteChromeRegistrationKeys(BrowserDistribution* dist, HKEY root,
// lives in HKLM.
InstallUtil::DeleteRegistryValueIf(
root, ShellUtil::kRegStartMenuInternet, L"",
- InstallUtil::ValueEquals(dist->GetApplicationName() +
- browser_entry_suffix));
+ InstallUtil::ValueEquals(dist->GetBaseAppName() + browser_entry_suffix));
// Delete each protocol association if it references this Chrome.
InstallUtil::ProgramCompare open_command_pred(chrome_exe);
@@ -712,7 +711,7 @@ InstallStatus UninstallProduct(const InstallationState& original_state,
bool is_chrome = product.is_chrome();
- VLOG(1) << "UninstallProduct: " << browser_dist->GetApplicationName();
+ VLOG(1) << "UninstallProduct: " << browser_dist->GetBaseAppName();
if (force_uninstall) {
// Since --force-uninstall command line option is used, we are going to

Powered by Google App Engine
This is Rietveld 408576698