Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7256)

Unified Diff: chrome/installer/util/browser_distribution.h

Issue 10446111: Abstract suffixing logic away from GetApplicationName (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/browser_distribution.h
diff --git a/chrome/installer/util/browser_distribution.h b/chrome/installer/util/browser_distribution.h
index 7b703fa8b7f91e506106df9e34d8eba5176ee5cd..68d4fc58bbd20ca3ab96df62de9878ea84d6c92b 100644
--- a/chrome/installer/util/browser_distribution.h
+++ b/chrome/installer/util/browser_distribution.h
@@ -69,8 +69,15 @@ class BrowserDistribution {
// Returns the name by which the program is registered with Default Programs.
// This is not a localized string suitable for presenting to a user.
- // This name should then usually be suffixed for user-level installs.
- virtual string16 GetApplicationName();
+ // The name returned will already be suffixed, if necessary, for user-level
+ // installs.
+ string16 GetAppName();
+
+ // Returns the unsuffixed application name of this program.
+ // IMPORTANT: This should only be called by the installer which needs to make
+ // decisions on the suffixing of the upcoming install (or by logging code that
+ // doesn't care about the suffixes), not by external callers at run-time.
+ virtual string16 GetUnsuffixedAppName();
// Returns the localized name of the program.
virtual string16 GetAppShortCutName();

Powered by Google App Engine
This is Rietveld 408576698