Abstract suffixing logic away from GetApplicationName

chrome/installer/util/browser_distribution.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file declares a class that contains various method related to branding.
 
 #ifndef CHROME_INSTALLER_UTIL_BROWSER_DISTRIBUTION_H_
 #define CHROME_INSTALLER_UTIL_BROWSER_DISTRIBUTION_H_
 #pragma once
 
@@ skipping 49 matching lines @@
   static BrowserDistribution* GetSpecificDistribution(Type type);
 
   Type GetType() const { return type_; }
 
   virtual void DoPostUninstallOperations(const Version& version,
                                          const FilePath& local_data_path,
                                          const string16& distribution_data);
 
   virtual string16 GetAppGuid();
 
-  // Returns the name by which the program is registered with Default Programs.
-  // This is not a localized string suitable for presenting to a user.
-  virtual string16 GetApplicationName();
+  // Returns the unsuffixed application name of this program.

[grt (UTC plus 2), 2012/06/08 19:54:21]

I think the mention of "Default Programs" was useful for the reader (i.e., what
the application name is used for).

[gab, 2012/06/11 16:04:40]

Done.

+  // IMPORTANT: This should only be called by the installer which needs to make
+  // decisions on the suffixing of the upcoming install (or by logging code that
+  // doesn't care about the suffixes), not by external callers at run-time.
+  virtual string16 GetBaseAppName();
 
   // Returns the localized name of the program.
   virtual string16 GetAppShortCutName();
 
   virtual string16 GetAlternateApplicationName();
 
   virtual string16 GetBrowserAppId();
 
   virtual string16 GetInstallSubDir();
 
@@ skipping 79 matching lines @@
 
   const Type type_;
 
  private:
   BrowserDistribution();
 
   DISALLOW_COPY_AND_ASSIGN(BrowserDistribution);
 };
 
 #endif  // CHROME_INSTALLER_UTIL_BROWSER_DISTRIBUTION_H_