Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Unified Diff: lib/compiler/implementation/ssa/validate.dart

Issue 10446080: Address review comments from https://chromiumcodereview.appspot.com/10454049/. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/ssa/tracer.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/validate.dart
===================================================================
--- lib/compiler/implementation/ssa/validate.dart (revision 8091)
+++ lib/compiler/implementation/ssa/validate.dart (working copy)
@@ -83,8 +83,9 @@
if (!isValid) return;
block.forEachPhi(visitInstruction);
- // Make sure the parameters of a phi are dominating the
- // corresponding predecessor block.
+ // Make sure the blocks of the parameters of a phi are dominating the
Lasse Reichstein Nielsen 2012/05/31 07:11:58 Pedantry: "Make sure" -> "Check that". If you "mak
ngeoffray 2012/05/31 08:16:16 Done.
+ // corresponding predecessor block. Note that block dominates
Lasse Reichstein Nielsen 2012/05/31 07:11:58 "block dominates" -> "blocks dominate" (or "a bloc
ngeoffray 2012/05/31 08:16:16 Done.
+ // themselves.
block.forEachPhi((HPhi phi) {
for (int i = 0; i < phi.inputs.length; i++) {
HInstruction input = phi.inputs[i];
@@ -94,8 +95,8 @@
}
});
- // Make sure the inputs of an instruction dominate the
- // instruction.
+ // Make sure the blocks of the inputs of an instruction dominate the
+ // instruction's block.
block.forEachInstruction((HInstruction instruction) {
for (HInstruction input in instruction.inputs) {
if (!input.block.dominates(block)) {
« no previous file with comments | « lib/compiler/implementation/ssa/tracer.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698