content/common/android/process_main.h - Issue 10444121: Added android_browser_process.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/common/android/process_main.h

Issue 10444121: Added android_browser_process. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Init Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CONTENT_COMMON_ANDROID_PROCESS_MAIN_H_

	6 #define CONTENT_COMMON_ANDROID_PROCESS_MAIN_H_

	7 #pragma once

	8

	9 #include <jni.h>

	10

	11 namespace content {

	12

	13 class ContentMainDelegate;

	14

	15 extern content::ContentMainDelegate* g_content_main_delegate;
	jam 2012/06/01 22:04:55 we usually don't expose globals this way, both in we usually don't expose globals this way, both in normal headers in content, and especially in the content api which this appears to need to move to since you need it in content/shell. content_shell is a test program around content, so it can only access the public API of content michaelbai 2012/06/01 23:27:20 Added InitContentMainDelegate in content/public/ap Added InitContentMainDelegate in content/public/app/content_main.h, and implement it in content/app/android/content_main.cc On 2012/06/01 22:04:55, John Abd-El-Malek wrote: Show quoted text > we usually don't expose globals this way, both in normal headers in content, and > especially in the content api which this appears to need to move to since you > need it in content/shell. content_shell is a test program around content, so it > can only access the public API of content
	16

	17 bool InitProcess(JNIEnv* env, jobject context);
	jam 2012/06/01 22:04:55 should this file really be in content/common? isn' should this file really be in content/common? isn't the analogous non-android version of this file ContentMain? that's in content/app michaelbai 2012/06/01 23:27:20 Right! this doesn't need, and could by merge with Right! this doesn't need, and could by merge with content_main. Removed process_main.{h\|cc}, and moved the logical to InitApplicationContext() in content/android/content_main.cc On 2012/06/01 22:04:55, John Abd-El-Malek wrote: Show quoted text > should this file really be in content/common? isn't the analogous non-android > version of this file ContentMain? that's in content/app
	18

	19 } // namespace content

	20

	21 #endif // CONTENT_COMMON_ANDROID_PROCESS_MAIN_H_

OLD	NEW

« no previous file with comments | « content/app/android/content_main.cc ('k') | content/common/android/process_main.cc » ('j') | content/shell/android/shell_library_loader.cc » ('J')