Fix gcc 4.6 compile issues; set but unused variable and pointer/FALSE fubar.

chrome/browser/chromeos/external_metrics_unittest.cc

Index: chrome/browser/chromeos/external_metrics_unittest.cc
diff --git a/chrome/browser/chromeos/external_metrics_unittest.cc b/chrome/browser/chromeos/external_metrics_unittest.cc
index 9f69b91253cd850322c06412412fb36c4cf698f9..52b6750df7c9b985055da89dca0fe173765f62c3 100644
--- a/chrome/browser/chromeos/external_metrics_unittest.cc
+++ b/chrome/browser/chromeos/external_metrics_unittest.cc
@@ -24,10 +24,9 @@ class ExternalMetricsTest : public testing::Test {
 static void SendMessage(const char* path, const char* name, const char* value) {
   int fd = open(path, O_CREAT | O_APPEND | O_WRONLY, 0666);
   int32 l = strlen(name) + strlen(value) + 2 + sizeof(l);
-  int num_bytes;
-  num_bytes = write(fd, &l, sizeof(l));
-  num_bytes = write(fd, name, strlen(name) + 1);
-  num_bytes = write(fd, value, strlen(value) + 1);

[jar (doing other things), 2012/06/01 00:42:39]

Clearly someone was thinking about checking to be sure we wrote... so what about
adding the:
EXPECT_EQ(num_bytes, ...);
after each assignment?

...or... if you wanted... you could have:
num_bytes += write(...)
on each line, and then do one big expect:
EXPECT_EQ(num_bytes, sizeof(l) + strlen(name) + strlen(value) + 2);

[Jói, 2012/06/01 09:58:31]

Done.

+  write(fd, &l, sizeof(l));
+  write(fd, name, strlen(name) + 1);
+  write(fd, value, strlen(value) + 1);
   close(fd);
 }