Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: chrome/browser/policy/device_policy_cache_unittest.cc

Issue 10443125: Allow re-enrollment to the same domain in case of policy data loss. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed unit tests. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/device_policy_cache_unittest.cc
diff --git a/chrome/browser/policy/device_policy_cache_unittest.cc b/chrome/browser/policy/device_policy_cache_unittest.cc
index fb2009e1b892b9b8928211c9d6b563e87e69a5a5..f4420ed9af9d704c56a936b59759ab646e4653e6 100644
--- a/chrome/browser/policy/device_policy_cache_unittest.cc
+++ b/chrome/browser/policy/device_policy_cache_unittest.cc
@@ -192,7 +192,7 @@ TEST_F(DevicePolicyCacheTest, SetPolicy) {
cache_->RemoveObserver(&observer_);
}
-TEST_F(DevicePolicyCacheTest, SetPolicyWrongUser) {
+TEST_F(DevicePolicyCacheTest, SetPolicyOtherUserSameDomain) {
InSequence s;
MakeEnterpriseDevice(kTestUser);
@@ -209,7 +209,34 @@ TEST_F(DevicePolicyCacheTest, SetPolicyWrongUser) {
// Set new policy information. This should fail due to invalid user.
Mattias Nissler (ping if slow) 2012/06/04 10:17:52 comment is outdated.
pastarmovj 2012/06/08 09:54:32 Done.
em::PolicyFetchResponse new_policy;
- CreateRefreshRatePolicy(&new_policy, "foreign_user@example.com", 300);
+ CreateRefreshRatePolicy(&new_policy, "another_user@example.com", 300);
+ EXPECT_CALL(signed_settings_helper_, StartStorePolicyOp(_, _)).Times(1);
+ EXPECT_TRUE(cache_->SetPolicy(new_policy));
+ Mock::VerifyAndClearExpectations(&signed_settings_helper_);
+
+ base::FundamentalValue expected(120);
+ EXPECT_TRUE(Value::Equals(&expected,
+ GetPolicy(key::kDevicePolicyRefreshRate)));
+}
+
+TEST_F(DevicePolicyCacheTest, SetPolicyOtherUserOtherDomain) {
+ InSequence s;
+
+ MakeEnterpriseDevice(kTestUser);
+
+ // Startup.
+ em::PolicyFetchResponse policy;
+ CreateRefreshRatePolicy(&policy, kTestUser, 120);
+ EXPECT_CALL(signed_settings_helper_, StartRetrievePolicyOp(_)).WillOnce(
+ MockSignedSettingsHelperRetrievePolicy(SignedSettings::SUCCESS,
+ policy));
+ EXPECT_CALL(observer_, OnCacheUpdate(cache_.get()));
+ cache_->Load();
+ Mock::VerifyAndClearExpectations(&signed_settings_helper_);
+
+ // Set new policy information. This should fail due to invalid user.
+ em::PolicyFetchResponse new_policy;
+ CreateRefreshRatePolicy(&new_policy, "foreign_user@hackers.com", 300);
EXPECT_CALL(signed_settings_helper_, StartStorePolicyOp(_, _)).Times(0);
EXPECT_FALSE(cache_->SetPolicy(new_policy));
Mock::VerifyAndClearExpectations(&signed_settings_helper_);

Powered by Google App Engine
This is Rietveld 408576698