chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc - Issue 10443105: Take 2 at implementing activeTab.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc

Issue 10443105: Take 2 at implementing activeTab. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: a unit test Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc

diff --git a/chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc b/chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc

index 4b9b22f568e7cdfc5e5fed05a76be385926f06ac..c65981e82172ebca4175c25635fba827b5a54478 100644

--- a/chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc

+++ b/chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc

@@ -802,7 +802,7 @@ bool UpdateOffscreenTabFunction::RunImpl() {

tab_contents_ = offscreen_tab->tab_contents();

bool is_async = false;

- if (!UpdateURLIfPresent(update_props, &is_async))

+ if (!UpdateURLIfPresent(update_props, offscreen_tab_id, &is_async))

return false;

// Update the width and height, if specified.