Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Unified Diff: src/mksnapshot.cc

Issue 10443085: Report syntax errors in natives when building with mksnapshot. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/mksnapshot.cc
===================================================================
--- src/mksnapshot.cc (revision 11679)
+++ src/mksnapshot.cc (working copy)
@@ -302,7 +302,13 @@
}
#endif
i::Serializer::Enable();
+ TryCatch try_catch(NULL);
Persistent<Context> context = v8::Context::New();
+ if (try_catch.HasCaught()) {
+ fprintf(stderr,
+ "\nException thrown while compiling natives - see above.\n\n");
+ exit(1);
+ }
ASSERT(!context.IsEmpty());
// Make sure all builtin scripts are cached.
{ HandleScope scope;

Powered by Google App Engine
This is Rietveld 408576698