Added chrome switch that lets tests override URL path, moved GAIA auth extension from CrOS

Added chrome switch that lets tests override URL path prefix for GAIA login requests. Moved GAIA auth extension to Chrome resources. 

BUG=129644
TEST=make sure gaia enterprise enrolment tests work when we pass additional --gaia-url-path switch
TBR=csilv (chrome/browser/resources part)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139134

[Nikita (slow), 2012-05-25 19:37:17]

lgtm

https://chromiumcodereview.appspot.com/10443024/diff/9001/chrome/browser/reso...
File chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js
(left):

https://chromiumcodereview.appspot.com/10443024/diff/9001/chrome/browser/reso...
chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js:187: if
(data.gaiaOrigin)
Why this check was removed?
Still exists in screen_gaia_signin.js

[xiyuan, 2012-05-25 20:03:12]

LGTM with nits.

https://chromiumcodereview.appspot.com/10443024/diff/9001/chrome/browser/reso...
File chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js
(left):

https://chromiumcodereview.appspot.com/10443024/diff/9001/chrome/browser/reso...
chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js:187: if
(data.gaiaOrigin)
On 2012/05/25 19:37:17, Nikita Kostylev wrote:
> Why this check was removed?
> Still exists in screen_gaia_signin.js

If data.gaiaOrigin is missing, we actually would create a bad URL as the "?"
would be missing. Since it is working fine, I guess data.gaiaOrigin must always
exist.

Otherwise, think we should do the same trick as in screen_gaia_signin.js, i.e.
create a param list and join it later with "&" and decide whether a "?" is
needed at that time.

https://chromiumcodereview.appspot.com/10443024/diff/9001/chrome/browser/reso...
File chrome/browser/resources/component_extension_resources.grd (right):

https://chromiumcodereview.appspot.com/10443024/diff/9001/chrome/browser/reso...
chrome/browser/resources/component_extension_resources.grd:33: <include
name="IDR_GAIA_AUTH_UTIL_CSS" file="gaia_auth/util.js" type="BINDATA" />
nit: IDR_GAIA_AUTH_UTIL_CSS -> IDR_GAIA_AUTH_UTIL_JS

https://chromiumcodereview.appspot.com/10443024/diff/9001/chrome/browser/reso...
chrome/browser/resources/component_extension_resources.grd:34: <include
name="IDR_GAIA_AUTH_TEST_CONTENT_CSS" file="gaia_auth/test/content.js"
type="BINDATA" />
nit: IDR_GAIA_AUTH_TEST_CONTENT_CSS -> IDR_GAIA_AUTH_TEST_CONTENT_JS

[zel, 2012-05-25 20:13:45]

https://chromiumcodereview.appspot.com/10443024/diff/9001/chrome/browser/reso...
File chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js
(left):

https://chromiumcodereview.appspot.com/10443024/diff/9001/chrome/browser/reso...
chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js:187: if
(data.gaiaOrigin)
On 2012/05/25 20:03:12, xiyuan wrote:
> On 2012/05/25 19:37:17, Nikita Kostylev wrote:
> > Why this check was removed?
> > Still exists in screen_gaia_signin.js
> 
> If data.gaiaOrigin is missing, we actually would create a bad URL as the "?"
> would be missing. Since it is working fine, I guess data.gaiaOrigin must
always
> exist.
> 
> Otherwise, think we should do the same trick as in screen_gaia_signin.js, i.e.
> create a param list and join it later with "&" and decide whether a "?" is
> needed at that time.

Yes, this param exists always.

https://chromiumcodereview.appspot.com/10443024/diff/9001/chrome/browser/reso...
File chrome/browser/resources/component_extension_resources.grd (right):

https://chromiumcodereview.appspot.com/10443024/diff/9001/chrome/browser/reso...
chrome/browser/resources/component_extension_resources.grd:33: <include
name="IDR_GAIA_AUTH_UTIL_CSS" file="gaia_auth/util.js" type="BINDATA" />
On 2012/05/25 20:03:12, xiyuan wrote:
> nit: IDR_GAIA_AUTH_UTIL_CSS -> IDR_GAIA_AUTH_UTIL_JS

Done.

https://chromiumcodereview.appspot.com/10443024/diff/9001/chrome/browser/reso...
chrome/browser/resources/component_extension_resources.grd:34: <include
name="IDR_GAIA_AUTH_TEST_CONTENT_CSS" file="gaia_auth/test/content.js"
type="BINDATA" />
On 2012/05/25 20:03:12, xiyuan wrote:
> nit: IDR_GAIA_AUTH_TEST_CONTENT_CSS -> IDR_GAIA_AUTH_TEST_CONTENT_JS

Done.

[asargent_no_longer_on_chrome, 2012-05-25 21:49:31]

LGTM

[csilv, 2012-05-25 22:38:39]

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
File chrome/browser/resources/gaia_auth/main.css (right):

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth/main.css:8: margin: 0px;
nit: remove 'px' for 0 values.

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
File chrome/browser/resources/gaia_auth/main.html (right):

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth/main.html:6: <body><iframe id="gaia-frame"
src="about:blank"
nit: put link & script tags inside <head></head>

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth/main.html:6: <body><iframe id="gaia-frame"
src="about:blank"
nit: add: <meta charset="utf-8">

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth/main.html:7:
frameborder="0"></iframe></body></html>
nit: add linebreaks before </body> and </html>

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
File chrome/browser/resources/gaia_auth/main.js (right):

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth/main.js:1: function Authenticator() {
nit: add chromium copyright header

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth/main.js:29: console.log('###
Authenticator.initialize');
remove console.log unless there is a good reason to keep them (here and below,
all .js files).  alternatively, TODO to remove these later on.

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
File chrome/browser/resources/gaia_auth/offline.css (right):

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth/offline.css:32: min-height: 100%;
nit: alphabetical order for 'position' and 'min-height'

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth/offline.css:102: -o-transition: all 218ms;
nit: don't need to keep -ms, -o attributes (here and below)

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth/offline.css:106: border-radius: 2px;
nit: order 'border-radius' after 'border'.

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth/offline.css:108: background-image:
-webkit-gradient(linear,left top,left bottom,from(#f5f5f5),to(#f1f1f1));
don't need -webkit-gradient, overridden by -webkit-linear-gradient. (here and
below)

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth/offline.css:114: display: inline-block;
nit: move 'display' below 'cursor'.

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth/offline.css:140: }
nit: unnecessary indent on 138, extra on 139

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth/offline.css:152: box-shadow: 0 1px 1px
rgba(0,0,0,0.1);
nit: order 'box-shadow' after 'border'.

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
File chrome/browser/resources/gaia_auth/offline.html (right):

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth/offline.html:3: <head>
nit: add: <meta charset="utf-8">

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
File chrome/browser/resources/gaia_auth/offline.js (right):

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth/offline.js:17: var errorSpan =
$('errormsg-alert');
nit/optional.  these vars are only used once, would be preferrable to inline
into lines 19-23.

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
File chrome/browser/resources/gaia_auth/success.html (right):

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth/success.html:3: <script
src="util.js"></script>
nit: put script tags inside <head></head>
nit: add: <meta charset="utf-8">

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
File chrome/browser/resources/gaia_auth/success.js (right):

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth/success.js:1: function load() {
nit: add copyright header

[zel, 2012-05-25 23:33:52]

All fixes below are made in  https://chromiumcodereview.appspot.com/10440061

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
File chrome/browser/resources/gaia_auth/main.css (right):

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth/main.css:8: margin: 0px;
On 2012/05/25 22:38:39, csilv wrote:
> nit: remove 'px' for 0 values.

Done.

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
File chrome/browser/resources/gaia_auth/main.html (right):

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth/main.html:6: <body><iframe id="gaia-frame"
src="about:blank"
On 2012/05/25 22:38:39, csilv wrote:
> nit: put link & script tags inside <head></head>

Done.

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth/main.html:6: <body><iframe id="gaia-frame"
src="about:blank"
On 2012/05/25 22:38:39, csilv wrote:
> nit: put link & script tags inside <head></head>

Done.

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth/main.html:7:
frameborder="0"></iframe></body></html>
On 2012/05/25 22:38:39, csilv wrote:
> nit: add linebreaks before </body> and </html>

Done.

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
File chrome/browser/resources/gaia_auth/main.js (right):

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth/main.js:1: function Authenticator() {
On 2012/05/25 22:38:39, csilv wrote:
> nit: add chromium copyright header

Done.

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth/main.js:29: console.log('###
Authenticator.initialize');
On 2012/05/25 22:38:39, csilv wrote:
> remove console.log unless there is a good reason to keep them (here and below,
> all .js files).  alternatively, TODO to remove these later on.

Done. Kept those that report real errors.

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
File chrome/browser/resources/gaia_auth/offline.css (right):

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth/offline.css:32: min-height: 100%;
On 2012/05/25 22:38:39, csilv wrote:
> nit: alphabetical order for 'position' and 'min-height'

Done.

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth/offline.css:102: -o-transition: all 218ms;
On 2012/05/25 22:38:39, csilv wrote:
> nit: don't need to keep -ms, -o attributes (here and below)

Done.

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth/offline.css:106: border-radius: 2px;
On 2012/05/25 22:38:39, csilv wrote:
> nit: order 'border-radius' after 'border'.

Done.

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth/offline.css:108: background-image:
-webkit-gradient(linear,left top,left bottom,from(#f5f5f5),to(#f1f1f1));
On 2012/05/25 22:38:39, csilv wrote:
> don't need -webkit-gradient, overridden by -webkit-linear-gradient. (here and
> below)

Done.

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth/offline.css:114: display: inline-block;
On 2012/05/25 22:38:39, csilv wrote:
> nit: move 'display' below 'cursor'.

Done.

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth/offline.css:140: }
On 2012/05/25 22:38:39, csilv wrote:
> nit: unnecessary indent on 138, extra on 139

Done.

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth/offline.css:152: box-shadow: 0 1px 1px
rgba(0,0,0,0.1);
On 2012/05/25 22:38:39, csilv wrote:
> nit: order 'box-shadow' after 'border'.

Done.

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
File chrome/browser/resources/gaia_auth/offline.html (right):

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth/offline.html:3: <head>
On 2012/05/25 22:38:39, csilv wrote:
> nit: add: <meta charset="utf-8">

Done.

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
File chrome/browser/resources/gaia_auth/offline.js (right):

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth/offline.js:17: var errorSpan =
$('errormsg-alert');
On 2012/05/25 22:38:39, csilv wrote:
> nit/optional.  these vars are only used once, would be preferrable to inline
> into lines 19-23.

Done.

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
File chrome/browser/resources/gaia_auth/success.html (right):

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth/success.html:3: <script
src="util.js"></script>
On 2012/05/25 22:38:39, csilv wrote:
> nit: put script tags inside <head></head>
> nit: add: <meta charset="utf-8">

Done.

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
File chrome/browser/resources/gaia_auth/success.js (right):

http://codereview.chromium.org/10443024/diff/2004/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth/success.js:1: function load() {
On 2012/05/25 22:38:39, csilv wrote:
> nit: add copyright header

Done.

[Steve Block, 2012-06-11 17:39:08]

https://chromiumcodereview.appspot.com/10443024/diff/8028/chrome/browser/reso...
File chrome/browser/resources/gaia_auth/test/content.js (right):

https://chromiumcodereview.appspot.com/10443024/diff/8028/chrome/browser/reso...
chrome/browser/resources/gaia_auth/test/content.js:3: // found in the LICENSE
file.
Did you intend for some of these resource files to use a non-standard license
header?

If this really is CrOS code, I believe the policy is that all third-party code
should live in a directory named 'third-party' -
http://www.chromium.org/developers/adding-3rd-party-libraries

If not, we should fix the copyright and the date.