Implement implicit instance checks for API accessors.

include/v8.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 82 matching lines @@
 class Uint32;
 class External;
 class Primitive;
 class Boolean;
 class BooleanObject;
 class Integer;
 class Function;
 class Date;
 class ImplementationUtilities;
 class Signature;
+class AccessorSignature;
 template <class T> class Handle;
 template <class T> class Local;
 template <class T> class Persistent;
 class FunctionTemplate;
 class ObjectTemplate;
 class Data;
 class AccessorInfo;
 class StackTrace;
 class StackFrame;
 class Isolate;
@@ skipping 2169 matching lines @@
    */
   bool HasInstance(Handle<Value> object);
 
  private:
   FunctionTemplate();
   void AddInstancePropertyAccessor(Handle<String> name,
                                    AccessorGetter getter,
                                    AccessorSetter setter,
                                    Handle<Value> data,
                                    AccessControl settings,
-                                   PropertyAttribute attributes);
+                                   PropertyAttribute attributes,
+                                   Handle<AccessorSignature> signature);
   void SetNamedInstancePropertyHandler(NamedPropertyGetter getter,
                                        NamedPropertySetter setter,
                                        NamedPropertyQuery query,
                                        NamedPropertyDeleter remover,
                                        NamedPropertyEnumerator enumerator,
                                        Handle<Value> data);
   void SetIndexedInstancePropertyHandler(IndexedPropertyGetter getter,
                                          IndexedPropertySetter setter,
                                          IndexedPropertyQuery query,
                                          IndexedPropertyDeleter remover,
@@ skipping 37 matching lines @@
    * \param settings Access control settings for the accessor. This is a bit
    *   field consisting of one of more of
    *   DEFAULT = 0, ALL_CAN_READ = 1, or ALL_CAN_WRITE = 2.
    *   The default is to not allow cross-context access.
    *   ALL_CAN_READ means that all cross-context reads are allowed.
    *   ALL_CAN_WRITE means that all cross-context writes are allowed.
    *   The combination ALL_CAN_READ | ALL_CAN_WRITE can be used to allow all
    *   cross-context access.
    * \param attribute The attributes of the property for which an accessor
    *   is added.
+   * \param signature The signature describes valid receivers for the accessor
+   *   and is used to perform implicit instance checks against. If the receiver

[danno, 2012/06/06 09:32:31]

nit: against them.

[Michael Starzinger, 2012/06/08 07:40:44]

Done.

+   *   is incompatible (i.e. is not an instance of the constructor as defined
+   *   by FunctionTemplate::HasInstance()), an implicit TypeError is thrown and
+   *   no callback is invoked.
    */
   void SetAccessor(Handle<String> name,
                    AccessorGetter getter,
                    AccessorSetter setter = 0,
                    Handle<Value> data = Handle<Value>(),
                    AccessControl settings = DEFAULT,
-                   PropertyAttribute attribute = None);
+                   PropertyAttribute attribute = None,
+                   Handle<AccessorSignature> signature =
+                       Handle<AccessorSignature>());
 
   /**
    * Sets a named property handler on the object template.
    *
    * Whenever a named property is accessed on objects created from
    * this object template, the provided callback is invoked instead of
    * accessing the property directly on the JavaScript object.
    *
    * \param getter The callback to invoke when getting a property.
    * \param setter The callback to invoke when setting a property.
@@ skipping 98 matching lines @@
   static Local<Signature> New(Handle<FunctionTemplate> receiver =
                                   Handle<FunctionTemplate>(),
                               int argc = 0,
                               Handle<FunctionTemplate> argv[] = 0);
  private:
   Signature();
 };
 
 
 /**
+ * An AccessorSignature specifies which receivers an accessor callback
+ * can legally be called with.

[danno, 2012/06/06 09:32:31]

how about: "An AccessorSignature specifies which receivers are valid arguments
to an accessor callback."  

[Michael Starzinger, 2012/06/08 07:40:44]

Done. Also applied to "Signature" a few lines above.

+ */
+class V8EXPORT AccessorSignature : public Data {
+ public:
+  static Local<AccessorSignature> New(Handle<FunctionTemplate> receiver =
+                                          Handle<FunctionTemplate>());
+ private:
+  AccessorSignature();
+};
+
+
+/**
  * A utility for determining the type of objects based on the template
  * they were constructed from.
  */
 class V8EXPORT TypeSwitch : public Data {
  public:
   static Local<TypeSwitch> New(Handle<FunctionTemplate> type);
   static Local<TypeSwitch> New(int argc, Handle<FunctionTemplate> types[]);
   int match(Handle<Value> value);
  private:
   TypeSwitch();
@@ skipping 1989 matching lines @@
 
 
 }  // namespace v8
 
 
 #undef V8EXPORT
 #undef TYPE_CHECK
 
 
 #endif  // V8_H_