net/dns/dns_response.cc - Issue 10442098: [net/dns] Resolve AF_UNSPEC on dual-stacked systems. Sort addresses according to RFC3484.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/dns/dns_response.cc

Issue 10442098: [net/dns] Resolve AF_UNSPEC on dual-stacked systems. Sort addresses according to RFC3484. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Working AddressSorterWin + measurements. Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/dns/dns_response.cc

diff --git a/net/dns/dns_response.cc b/net/dns/dns_response.cc

index 4ad6465fbfd8ce8ffc51fa9a312783b0cd23b252..c8e706e34d08349d80a4991f3578950cf4ae9056 100644

--- a/net/dns/dns_response.cc

+++ b/net/dns/dns_response.cc

@@ -280,8 +280,6 @@ DnsResponse::Result DnsResponse::ParseToAddressList(

}

// TODO(szym): Extract TTL for NODATA results. http://crbug.com/115051

- if (ip_addresses.empty())

- return DNS_NO_ADDRESSES;

// getcanonname in eglibc returns the first owner name of an A or AAAA RR.

// If the response passed all the checks so far, then |expected_name| is it.

« net/dns/address_sorter_win.cc ('K') | « net/dns/dns_client.cc ('k') | net/dns/dns_test_util.cc » ('j') | no next file with comments »