Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Unified Diff: remoting/host/clipboard_util_unittest.cc

Issue 10441131: [Chromoting] Handle CR-LF correctly when transferring text items to and from the clipboard on a Win… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/clipboard_util_unittest.cc
diff --git a/remoting/host/clipboard_util_unittest.cc b/remoting/host/clipboard_util_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..830d1469ff66503f089efbec0acfeccf61fc9f4a
--- /dev/null
+++ b/remoting/host/clipboard_util_unittest.cc
@@ -0,0 +1,79 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "remoting/host/clipboard_util.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace remoting {
+
+TEST(ClipboardUtilTest, ReplaceLfByCrLf) {
+ EXPECT_EQ("ab", ClipboardUtil::ReplaceLfByCrLf("ab"));
+ EXPECT_EQ("\r\nab", ClipboardUtil::ReplaceLfByCrLf("\nab"));
+ EXPECT_EQ("\r\nab\r\n", ClipboardUtil::ReplaceLfByCrLf("\nab\n"));
+ EXPECT_EQ("\r\nab\r\ncd", ClipboardUtil::ReplaceLfByCrLf("\nab\ncd"));
+ EXPECT_EQ("\r\nab\r\ncd\r\n", ClipboardUtil::ReplaceLfByCrLf("\nab\ncd\n"));
+ EXPECT_EQ("\r\n\r\nab\r\n\r\ncd\r\n\r\n",
+ ClipboardUtil::ReplaceLfByCrLf("\n\nab\n\ncd\n\n"));
+}
+
+TEST(ClipboardUtilTest, ReplaceLfByCrLfSpeed) {
+ int kLineSize = 128;
+ std::string line(kLineSize, 'a');
+ line[kLineSize - 1] = '\n';
+ // Make a 10M string.
+ int kLineNum = 10 * 1024 * 1024 / kLineSize;
+ std::string buffer;
+ buffer.resize(kLineNum * kLineSize);
+ for (int i = 0; i < kLineNum; ++i) {
+ memcpy(&buffer[i * kLineSize], &line[0], kLineSize);
+ }
+ // Convert the string.
+ buffer = ClipboardUtil::ReplaceLfByCrLf(buffer);
+ // Check the converted string.
+ EXPECT_EQ((kLineSize + 1) * kLineNum, buffer.size());
+ const char* p = &buffer[0];
+ for (int i = 0; i < kLineNum; ++i) {
+ EXPECT_EQ(0, memcmp(&line[0], p, kLineSize - 1));
+ p += kLineSize - 1;
+ EXPECT_EQ('\r', *p++);
+ EXPECT_EQ('\n', *p++);
+ }
+}
+
+TEST(ClipboardUtilTest, ReplaceCrLfByLf) {
+ EXPECT_EQ("ab", ClipboardUtil::ReplaceCrLfByLf("ab"));
+ EXPECT_EQ("\nab", ClipboardUtil::ReplaceCrLfByLf("\r\nab"));
+ EXPECT_EQ("\nab\n", ClipboardUtil::ReplaceCrLfByLf("\r\nab\r\n"));
+ EXPECT_EQ("\nab\ncd", ClipboardUtil::ReplaceCrLfByLf("\r\nab\r\ncd"));
+ EXPECT_EQ("\nab\ncd\n", ClipboardUtil::ReplaceCrLfByLf("\r\nab\r\ncd\n"));
+ EXPECT_EQ("\n\nab\n\ncd\n\n",
+ ClipboardUtil::ReplaceCrLfByLf("\r\n\r\nab\r\n\r\ncd\r\n\r\n"));
+ EXPECT_EQ("\rab\rcd\r", ClipboardUtil::ReplaceCrLfByLf("\rab\rcd\r"));
+}
+
+TEST(ClipboardUtilTest, ReplaceCrLfByLfSpeed) {
+ int kLineSize = 128;
+ std::string line(kLineSize, 'a');
+ line[kLineSize - 2] = '\r';
+ line[kLineSize - 1] = '\n';
+ // Make a 10M string.
+ int kLineNum = 10 * 1024 * 1024 / kLineSize;
+ std::string buffer;
+ buffer.resize(kLineNum * kLineSize);
+ for (int i = 0; i < kLineNum; ++i) {
+ memcpy(&buffer[i * kLineSize], &line[0], kLineSize);
+ }
+ // Convert the string.
+ buffer = ClipboardUtil::ReplaceCrLfByLf(buffer);
+ // Check the converted string.
+ EXPECT_EQ((kLineSize - 1) * kLineNum, buffer.size());
+ const char* p = &buffer[0];
+ for (int i = 0; i < kLineNum; ++i) {
+ EXPECT_EQ(0, memcmp(&line[0], p, kLineSize - 2));
+ p += kLineSize - 2;
+ EXPECT_EQ('\n', *p++);
+ }
+}
+
+} // namespace remoting

Powered by Google App Engine
This is Rietveld 408576698