Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Unified Diff: net/url_request/url_request_throttler_entry_interface.h

Issue 10440119: Introduce a delegate to avoid hardcoding "chrome-extension" in net/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Respond to review requests. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_throttler_entry_interface.h
diff --git a/net/url_request/url_request_throttler_entry_interface.h b/net/url_request/url_request_throttler_entry_interface.h
index e46cd2aded2a4fa5c25d72b6a07ca58967eb4d2c..289b0bd1a701b3f9241914b7f5386b5efe0ddc1b 100644
--- a/net/url_request/url_request_throttler_entry_interface.h
+++ b/net/url_request/url_request_throttler_entry_interface.h
@@ -15,6 +15,7 @@
namespace net {
+class URLRequest;
class URLRequestThrottlerHeaderInterface;
// Interface provided on entries of the URL request throttler manager.
@@ -26,11 +27,16 @@ class NET_EXPORT URLRequestThrottlerEntryInterface
// Returns true when we have encountered server errors and are doing
// exponential back-off, unless the request has |load_flags| (from
// net/base/load_flags.h) that mean it is likely to be
- // user-initiated.
+ // user-initiated, or the NetworkDelegate returns false for
+ // |CanRejectRequest(request)|.
+ //
+ // |request| may be NULL, in which the assumption is that the
+ // request may be rejected.
//
// URLRequestHttpJob checks this method prior to every request; it
// cancels requests if this method returns true.
- virtual bool ShouldRejectRequest(int load_flags) const = 0;
+ virtual bool ShouldRejectRequest(const URLRequest* request,
+ int load_flags) const = 0;
eroman 2012/06/06 04:52:11 is the load_flags parameter needed?
Jói 2012/06/06 13:38:55 Done.
// Calculates a recommended sending time for the next request and reserves it.
// The sending time is not earlier than the current exponential back-off

Powered by Google App Engine
This is Rietveld 408576698